-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): add Apollo 4 docs #12729
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 420 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @lbloder do the real review here, just left some comments.
|
||
## Using With Java | ||
|
||
Configure Global Hub Mode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h
Do we really need this? Enabling this on a backend would basically break Sentry.
I saw that we have this on older Apollo docs as well, so ideally we find a way to avoid suggesting this.
Is this just a relic of old times before we had support for coroutines as described below?
Does this only apply to using Apollo from Java?
We should probably add a sentence explaining that it's only meant for Java and also that this shouldn't be used on a backend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we just remove it from the java page then?
.build() | ||
``` | ||
|
||
## GraphQL Client Errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be on the Java part of docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not?
DESCRIBE YOUR PR
Adds docs for the (to be released) Apollo 4 integration getsentry/sentry-java#4166
To be merged after release
The content is copied from Apollo 3 docs. I have only changed imports and removed the callout speaking about version 4 being not supported by Sentry.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.