Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add Apollo 4 docs #12729

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

lcian
Copy link
Member

@lcian lcian commented Feb 14, 2025

DESCRIBE YOUR PR

Adds docs for the (to be released) Apollo 4 integration getsentry/sentry-java#4166
To be merged after release
The content is copied from Apollo 3 docs. I have only changed imports and removed the callout speaking about version 4 being not supported by Sentry.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 9:12am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 9:12am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 9:12am

Copy link

codecov bot commented Feb 14, 2025

Bundle Report

Changes will increase total bundle size by 420 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB 426 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/TmDLEC9_78ujecjuPavwW/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/TmDLEC9_78ujecjuPavwW/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/UzfSDbggriopW1jPxIfj-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 145 bytes 376.2kB 0.04%
../app/platform-redirect/page.js.nft.json 145 bytes 376.11kB 0.04%
../app/sitemap.xml/route.js.nft.json 145 bytes 374.08kB 0.04%

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @lbloder do the real review here, just left some comments.


## Using With Java

Configure Global Hub Mode:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h Do we really need this? Enabling this on a backend would basically break Sentry.
I saw that we have this on older Apollo docs as well, so ideally we find a way to avoid suggesting this.
Is this just a relic of old times before we had support for coroutines as described below?

Does this only apply to using Apollo from Java?
We should probably add a sentence explaining that it's only meant for Java and also that this shouldn't be used on a backend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about we just remove it from the java page then?

.build()
```

## GraphQL Client Errors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be on the Java part of docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

@lcian lcian requested a review from lbloder February 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants