-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tour): Implement the issue details tour #85970
base: leander/tour-analytics
Are you sure you want to change the base?
Conversation
❌ 42 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
1b87cf8
to
02b6fc2
Compare
93fc02b
to
10e92fe
Compare
ea49dc6
to
4c22522
Compare
10e92fe
to
99fb3ec
Compare
99fb3ec
to
3330dad
Compare
deec519
to
92446f7
Compare
3330dad
to
664631e
Compare
Bundle ReportChanges will increase total bundle size by 36.29kB (0.09%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
664631e
to
ddf55e8
Compare
ddf55e8
to
9f37933
Compare
9f37933
to
6669451
Compare
6669451
to
3ce532a
Compare
3ce532a
to
b8f9cdb
Compare
9017013
to
18587fc
Compare
jest.mock('sentry/views/issueDetails/issueDetailsTour', () => ({ | ||
...jest.requireActual('sentry/views/issueDetails/issueDetailsTour'), | ||
useIssueDetailsTour: () => mockTour(), | ||
})); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to do this kinda sucks, but it's not from wrapping TourElement
, it's from the rendering of <NewIssueExperienceButton />
which invokes useIssueDetailsTour()
. This component is rendered in the header, which seems to appear in all these testss
2d10e1e
to
af6c427
Compare
Implements the issue details tour when the
#tour
anchor is present.Screen.Recording.2025-03-05.at.3.13.42.PM.mov