BUGFIX: don't auto add parentheses for union (#192)

gocraft · Oct 15, 2019 · 7fac565 · 7fac565
1 parent 2b0519c
commit 7fac565
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/interpolate_test.go b/interpolate_test.go
@@ -124,7 +124,9 @@ func TestInterpolateForDialect(t *testing.T) {
 					Select("b").From("table2"),
 				).As("t"),
 			},
-			want: "((SELECT a FROM table1) UNION ALL (SELECT b FROM table2)) AS `t`",
+			// parentheses around union subqueries are not supported in sqlite
+			// but supported in both mysql and postgres.
+			want: "(SELECT a FROM table1 UNION ALL SELECT b FROM table2) AS `t`",
 		},
 		{
 			query: "?",

diff --git a/union.go b/union.go
@@ -34,8 +34,10 @@ func (u *union) Build(d Dialect, buf Buffer) error {
 				buf.WriteString("ALL ")
 			}
 		}
-		buf.WriteString(placeholder)
-		buf.WriteValue(b)
+		err := b.Build(d, buf)
+		if err != nil {
+			return err
+		}
 	}
 	return nil
 }