Add KernGroup type #725
Merged
Add KernGroup type #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Mar 6, 2024
fontir/src/ir.rs
Outdated
| s.strip_prefix("side1.") | ||
| .map(|s| KernGroup::Side1(s.into())) | ||
| .or_else(|| s.strip_prefix("side2.").map(|s| KernGroup::Side2(s.into()))) | ||
| .ok_or_else(|| D::Error::custom(format!("missing side1/side prefix: {s}"))) |
rsheeter
approved these changes
Mar 6, 2024
Merged
anthrotype
reviewed
Mar 7, 2024
| KernSide::Side2 => "public.kern2.", | ||
| } | ||
| } | ||
| fn parse_kern_group(name: &str) -> Option<KernGroup> { |
There was a problem hiding this comment.
(optional) could this be a method on KernGroup maybe? KernGroup::parse
There was a problem hiding this comment.
the issue is that the parsing behaviour depends on the backend, so it doesn't make sense to hang it off the common type.
This encodes in the type system the idea that kerning groups have an associated side, instead of having this be encoded as a prefix on a string. This removes the need to hae separate `KernSide` enums, and removes possible complications around using the same type for glyph names and group names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encodes in the type system the idea that kerning groups have an associated side, instead of having this be encoded as a prefix on a string.
This removes the need to hae separate
KernSideenums, and removes possible complications around using the same type for glyph names and group names.I was expecting this to be a smaller diff, but overall I think it's at least a modest improvement.