Multiple include: Levels & Labels #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…include-ui__levels
…include-ui__levels
gtk-grafana
changed the title
gtk-grafana
commented
Feb 19, 2025
gtk-grafana
commented
Feb 19, 2025
gtk-grafana
commented
Feb 19, 2025
gtk-grafana
commented
Feb 20, 2025
gtk-grafana
commented
Feb 20, 2025
| // We need at least one inclusive filter | ||
| if (this.options.type === 'indexed') { | ||
| if (filteredFilters.length < 1) { | ||
| filteredFilters = filters; |
There was a problem hiding this comment.
So if we have multiple include filters containing the exclude key, we would run the query with all of them. Maybe this is a reason to exclude the "primary" filter from breakdown views so we know that we're never excluding the only include filter.
But folks might want write a regex include e.g. cluster=~"us-.+", and then want to exclude stuff in the UI... but right now I believe this will behave as the current version, including will hide all other options, and excluding will remove that panel from the view (if they have no other inclusion label filters).
This comment was marked as outdated.
This comment was marked as outdated.
…include-ui__levels
* feat: multiple field includes --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>
matyax
reviewed
Feb 24, 2025
src/Components/ServiceScene/Breakdowns/LabelValuesBreakdownScene.tsx
Outdated
Show resolved
Hide resolved
src/Components/ServiceScene/Breakdowns/LabelValuesBreakdownScene.tsx
Outdated
Show resolved
Hide resolved
matyax
previously approved these changes
Feb 24, 2025
gtk-grafana
dismissed
matyax’s stale review
Made significant changes to how it works.
matyax
reviewed
Feb 25, 2025
matyax
reviewed
Feb 25, 2025
matyax
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing the ability to add multiple include filters in a value breakdown.
Related: