Multiple include: Fields & Metadata

[gtk-grafana]

Adding support for multiple includes in the value breakdown UI.
Parent branch: #1074

[matyax]

Looks great so far. A few things that I noticed:

• Going to the fields/labels breakdown triggers an unnecessary logsPanelQuery, just by opening the tab. It's the first query that is being executed.

Reload.mov

• The active state of filters in Log Details in inconsistent. Sometimes it shows as an active filter, other it doesnt. When clicked, it seems to remove filters but never add.

• When filtering for detected_level, applies the filter and selects the time series in Logs Volume, but it doesn't show in the top section.

• Removed the detected_level filter from log details, but it stayed in the top filters.

• It's not parsing multiple filters when coming from Explore

Explore.mov

[gtk-grafana]

Thanks for taking a look @matyax, good catches all around.

• Going to the fields/labels breakdown triggers an unnecessary logsPanelQuery, just by opening the tab. It's the first query that is being executed.

Yeah the logs panel query is not manually executed yet, it runs on every route/variable update in main right now as well.

Good catch with the logs panel filters, I'll take a look at this and the table filters as well here this morning.

It's not parsing multiple filters when coming from Explore

#1053
Yeah, right now there's no way to specify an or relation in field/line filters in the UI

Sorry just waking up, we added the or relation for positive filters in this PR lol, it's just or exclusion filters that would need UI support. That 1053 issue should be the next thing I work on and should probably go out on the same release as this PR.

[matyax]

Yeah the logs panel query is not manually executed yet, it runs on every route/variable update in main right now as well.

Not sure I follow. The logsPanelQuery ran to get the logs, but it will be executed again just by going to a tab. Is that needed for something?

[gtk-grafana]

I think (?) it's tech debt at this point from when we were parsing the labels/labelTypes from the log panel query, but it's possible those are still being used somewhere. I'll create an issue to convert that query runner to manually execute and we can investigate if that dataframe is still being used in the other scenes.

Created #1097 to track

[gtk-grafana]

@matyax logs panel should be fixed in ce0d515. I also fixed a bug where all negative filters were being generated with the "or" syntax (test coverage in 69b777f)

[matyax]

Fantastic 👌

[matyax]

Saw the !level btw, it's okay for now, and more importantly, it works.