feat: enhance debug_traceTransaction to work with Opcode Logger #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
victor-yanev
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
|
LGTM, one small nit |
natanasow
requested changes
May 31, 2024
Signed-off-by: nikolay <n.atanasow94@gmail.com>
natanasow
changed the title
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
Signed-off-by: Victor Yanev <victor.yanev@limechain.tech>
|
ebadiere
deleted the
2431-Enchance-debug_traceTransaction-to-work-with-opcode-logger
branch
quiet-node
pushed a commit
that referenced
this pull request
Jun 27, 2024
* feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: Remove unused imports and config variable in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: extract `getQueryParams` to helpers.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: fix validation Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: final touches Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: error message in param validations Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: fix expected error message in server.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: tests in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: remove unused import Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> --------- Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: nikolay <n.atanasow94@gmail.com> Co-authored-by: nikolay <n.atanasow94@gmail.com>
2 tasks
quiet-node
pushed a commit
that referenced
this pull request
Jun 27, 2024
* feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: Remove unused imports and config variable in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: extract `getQueryParams` to helpers.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: fix validation Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: final touches Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: error message in param validations Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: fix expected error message in server.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: tests in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: remove unused import Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> --------- Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: nikolay <n.atanasow94@gmail.com> Co-authored-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
added a commit
that referenced
this pull request
Jun 27, 2024
* feat: enhance debug_traceTransaction to work with Opcode Logger (#2480) * feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * feat: Enhance debug_traceTransaction to work with Opcode Logger Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: Remove unused imports and config variable in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: extract `getQueryParams` to helpers.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * chore: fix validation Signed-off-by: nikolay <n.atanasow94@gmail.com> * chore: final touches Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: error message in param validations Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * test: fix expected error message in server.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: tests in debug.spec.ts Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> * fix: remove unused import Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> --------- Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: nikolay <n.atanasow94@gmail.com> Co-authored-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * fix: debug_traceTransaction not working when we don't pass tracerConfig (#2628) Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Victor Yanev <victor.yanev@limechain.tech> Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Victor Yanev <161485803+victor-yanev@users.noreply.github.com> Co-authored-by: nikolay <n.atanasow94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the implemenation of
/api/v1/contracts/results/{transactionIdOrHash}/opcodesin theweb3module ofhedera-mirror-node, we can now utilise it by extending our support for debugging transactions.This PR:
debug_traceTransactionendpointdebug_traceTransactionwithTracerType.OpcodeLogger.Related issue(s):
Fixes #2431
Notes for reviewer:
Checklist