feat: Add Koa Server Request Timeout #2504

Nana-EC · 2024-05-17T04:43:20Z

Description:
Add Koa Server Request Timeout

Related issue(s):

Fixes #2503

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>

github-actions · 2024-05-17T04:47:44Z

Tests

    2 files 149 suites 13s ⏱️
833 tests 832 ✔️ 1 💤 0 ❌
845 runs 844 ✔️ 1 💤 0 ❌

Results for commit ddbd07c.

♻️ This comment has been updated with latest results.

github-actions · 2024-05-17T05:03:54Z

Acceptance Tests

    39 files   633 suites 1h 6m 8s ⏱️
  593 tests   581 ✔️   3 💤   9 ❌
2 668 runs 2 599 ✔️ 37 💤 32 ❌

Results for commit ddbd07c.

♻️ This comment has been updated with latest results.

Nana-EC · 2024-05-20T15:28:06Z

packages/server/src/index.ts

+  const server = await app.listen({ port: process.env.SERVER_PORT || 7546 });
+
+  // set request timeout to ensure sockets are closed after specified time
+  const requestTimeoutMs = parseInt(process.env.SERVER_REQUEST_TIMEOUT_MS!) || 30000;


Set timeout appropriately.
Maybe 60 secs or more.

Nana-EC · 2024-05-20T15:28:27Z

packages/server/src/index.ts

+
+  // set request timeout to ensure sockets are closed after specified time
+  const requestTimeoutMs = parseInt(process.env.SERVER_REQUEST_TIMEOUT_MS!) || 30000;
+  server.setTimeout(requestTimeoutMs);


Add a test to confirm relay sends timeout in this case

quiet-node · 2024-05-21T17:26:23Z

packages/server/tests/acceptance/rpc_batch3.spec.ts

@@ -2021,4 +2081,23 @@ describe('@api-batch-3 RPC Server Acceptance Tests', function () {
      }
    });
  });
+
+  describe.only('Koa Server Timeout', () => {


remove .only

Apologies, done.

quiet-node · 2024-05-21T17:26:26Z

packages/server/tests/acceptance/rpc_batch3.spec.ts

@@ -2021,4 +2081,23 @@ describe('@api-batch-3 RPC Server Acceptance Tests', function () {
      }
    });
  });
+
+  describe.only('Koa Server Timeout', () => {
+    it.only('should timeout a request after the specified time', async () => {


remove .only

quiet-node · 2024-05-21T17:26:39Z

packages/server/tests/localAcceptance.env

@@ -22,4 +22,5 @@ BATCH_REQUESTS_ENABLED=true
 TEST_GAS_PRICE_DEVIATION=0.2
 WS_NEW_HEADS_ENABLED=false
 INITIAL_BALANCE='5000000000'
-LIMIT_DURATION=90000
+LIMIT_DURATION=90000,
+SERVER_REQUEST_TIMEOUT_MS=3000


packages/server/src/index.ts

quiet-node · 2024-05-21T19:04:45Z

packages/server/tests/acceptance/rpc_batch3.spec.ts


 chai.use(chaiExclude);

+const sendJsonRpcRequestWithDelay = (


I'd suggest moving this method to helpers/utils.js or somewhere else to keep the batch 3 file clean. Also remove unsed import statements.

quiet-node · 2024-05-21T19:05:00Z

packages/server/tests/testnetAcceptance.env

@@ -15,3 +15,4 @@ SUBSCRIPTIONS_ENABLED=true
 FILTER_API_ENABLED=true
 DEBUG_API_ENABLED=true
 TEST_GAS_PRICE_DEVIATION=0.2
+SERVER_REQUEST_TIMEOUT_MS=60000


quiet-node · 2024-05-21T22:31:46Z

runnng the newly added test on local keep getting this error

1) RPC Server Acceptance Tests
       Acceptance tests
         @api-batch-3 RPC Server Acceptance Tests
           Koa Server Timeout
             should timeout a request after the specified time:
     AssertionError: expected undefined to equal 'ECONNRESET'
      at Suite.<anonymous> (packages/server/tests/acceptance/rpc_batch3.spec.ts:2038:29)
      at Generator.next (<anonymous>)
      at fulfilled (packages/server/tests/acceptance/rpc_batch3.spec.ts:47:58)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

AlfredoG87

Also we need to restore

import chaiExclude from 'chai-exclude';

AlfredoG87 · 2024-05-21T22:55:09Z

packages/server/src/index.ts

+
+  // set request timeout to ensure sockets are closed after specified time of inactivity
+  const requestTimeoutMs = parseInt(process.env.SERVER_REQUEST_TIMEOUT_MS || '60000');
+  server.setTimeout(requestTimeoutMs);


The setTimeout method allows to send a callback function that will be executed in case a timeout is executed:

I think we should use it to capture metrics of timeouts.

however, we don't have the registry yet in here...

so I was thinking if we can change the approach and do something like this??

I haven't tested this yet, but basically uses:
https://www.npmjs.com/package/koa-timeout

and move it to file Server.ts

and do it something like this:

// Custom middleware to increment the metric on timeout app.use(async (ctx, next) => { try { await next(); } catch (err) { if (err.message === 'Request timeout') { // Increment the timeout metric here // For example, using a metric library like Prometheus: // prometheusClient.counter('request_timeouts_total').inc(); console.log('Request timeout reached'); } throw err; } }); // Apply the timeout middleware app.use(timeout(5000)); // Set the timeout value in milliseconds

codecov-commenter · 2024-05-23T13:49:55Z

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 76.99%. Comparing base (8b45ca8) to head (36df19b).
Report is 12 commits behind head on main.

❗ Current head 36df19b differs from pull request most recent head f45244c

Please upload reports for the commit f45244c to get more accurate results.

Files	Patch %	Lines
packages/relay/src/lib/eth.ts	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
- Coverage   77.26%   76.99%   -0.27%     
==========================================
  Files          40       40              
  Lines        3229     3226       -3     
  Branches      663      667       +4     
==========================================
- Hits         2495     2484      -11     
- Misses        525      526       +1     
- Partials      209      216       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added doc updated. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped timeout to 60 seconds. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed only. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added empty line. Signed-off-by: ebadiere <ebadiere@gmail.com> Update packages/server/src/index.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added back the chai. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Restored the chai exclude Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed the async in the sendJsonRpcRequestWithDelay Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Reduced the timeout to allow tests to finish. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Moved timeout test to rateLimiter. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed comma after LIMIT_DURATION Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout delay to ensure it works in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Testing in CI. Removed the .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Adjusted the test delay. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added error details. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added more debug info. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added delay for linux. Debugging in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Setting test timeout Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Nested promise. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Including delay in testfile. Debugging CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CIfix: Debugging in CI. Updated package-log. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Extracted setting logic to util function to be used in server startup and test framework Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout for tests on local node. Signed-off-by: ebadiere <ebadiere@gmail.com>

Signed-off-by: ebadiere <ebadiere@gmail.com>

quiet-node

The test passed 🎊 🥂!!!
Some questions and suggestions.

.github/workflows/acceptance.yml

quiet-node · 2024-05-24T21:15:51Z

package-lock.json

@@ -9307,6 +9307,7 @@
      "resolved": "https://registry.npmjs.org/bufferutil/-/bufferutil-4.0.5.tgz",
      "integrity": "sha512-HTm14iMQKK2FjFLRTM5lAVcyaUzOnqbPtesFIvREgXpJHdQm8bWS+GkQgIkfaBYRHuCnea7w8UVNfwiAQhlr9A==",
      "dev": true,
+      "hasInstallScript": true,


I was wondering how come we have these changes?

The package-lock.json was mentioned as a suspect when we met to discuss the failing test in CI, so I included it. The hasInstallScript indicates that a package has an install script to run when installing.

quiet-node · 2024-05-24T21:18:43Z

packages/server/tests/acceptance/rateLimiter.spec.ts

@@ -158,4 +158,29 @@ describe('@ratelimiter Rate Limiters Acceptance Tests', function () {
      });
    });
  });
+
+  describe('Koa Server Timeout', () => {


Either we can cancel the server-config CI and have this test here, or we keep the server-config CI and remove this test in ratelimiter.

Agreed. That got missed in the back and forth. Removing.

quiet-node · 2024-05-24T21:19:11Z

packages/server/tests/acceptance/serverConfig.spec.ts

+import { expect } from 'chai';
+import { Utils } from '../helpers/utils';
+
+describe('@server-config Rate Limiters Acceptance Tests', function () {


Either we can cancel the server-config CI and have this test in ratelimiter, or we keep the server-config CI and remove this test here.

Agreed, see comment above and updated tests title.

packages/server/src/koaJsonRpc/lib/utils.ts

packages/server/tests/helpers/utils.ts

Signed-off-by: ebadiere <ebadiere@gmail.com>

sonarqubecloud · 2024-05-25T04:05:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

quiet-node

LGTM

AlfredoG87

LGTM

* Add Koa Server Request Timeout Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> * fix: Added test and documentation to the server request timeout setting. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added doc updated. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped timeout to 60 seconds. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed only. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added empty line. Signed-off-by: ebadiere <ebadiere@gmail.com> Update packages/server/src/index.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added back the chai. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Restored the chai exclude Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed the async in the sendJsonRpcRequestWithDelay Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Reduced the timeout to allow tests to finish. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Moved timeout test to rateLimiter. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed comma after LIMIT_DURATION Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout delay to ensure it works in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Testing in CI. Removed the .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Adjusted the test delay. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added error details. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added more debug info. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added delay for linux. Debugging in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Setting test timeout Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Nested promise. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Including delay in testfile. Debugging CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CIfix: Debugging in CI. Updated package-log. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Extracted setting logic to util function to be used in server startup and test framework Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout for tests on local node. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Moved into its own CI job. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Cleanup Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Clean up. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: ebadiere <ebadiere@gmail.com>

* Add Koa Server Request Timeout Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> * fix: Added test and documentation to the server request timeout setting. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added doc updated. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped timeout to 60 seconds. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed only. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added empty line. Signed-off-by: ebadiere <ebadiere@gmail.com> Update packages/server/src/index.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added back the chai. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Restored the chai exclude Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed the async in the sendJsonRpcRequestWithDelay Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Reduced the timeout to allow tests to finish. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Moved timeout test to rateLimiter. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed comma after LIMIT_DURATION Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout delay to ensure it works in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Testing in CI. Removed the .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Adjusted the test delay. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added error details. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added more debug info. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added delay for linux. Debugging in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Setting test timeout Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Nested promise. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Including delay in testfile. Debugging CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CIfix: Debugging in CI. Updated package-log. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Extracted setting logic to util function to be used in server startup and test framework Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout for tests on local node. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Moved into its own CI job. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Cleanup Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Clean up. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>

* Add Koa Server Request Timeout Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> * fix: Added test and documentation to the server request timeout setting. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added doc updated. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped timeout to 60 seconds. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: removed only. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added empty line. Signed-off-by: ebadiere <ebadiere@gmail.com> Update packages/server/src/index.ts Co-authored-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Signed-off-by: Eric Badiere <ebadiere@gmail.com> fix: Applied feedback Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added back the chai. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Restored the chai exclude Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed the async in the sendJsonRpcRequestWithDelay Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Reduced the timeout to allow tests to finish. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Moved timeout test to rateLimiter. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Removed comma after LIMIT_DURATION Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout delay to ensure it works in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Testing in CI. Removed the .only Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Adjusted the test delay. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added error details. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added more debug info. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Added delay for linux. Debugging in CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Setting test timeout Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CI. Nested promise. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Including delay in testfile. Debugging CI. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Debugging in CIfix: Debugging in CI. Updated package-log. Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Extracted setting logic to util function to be used in server startup and test framework Signed-off-by: ebadiere <ebadiere@gmail.com> fix: Bumped up the timeout for tests on local node. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Moved into its own CI job. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Cleanup Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Clean up. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: ebadiere <ebadiere@gmail.com>

feat: Add Koa Server Request Timeout (#2504) * Add Koa Server Request Timeout * fix: Added test and documentation to the server request timeout setting. fix: Added doc updated. fix: Bumped timeout to 60 seconds. fix: removed only. fix: Added empty line. Update packages/server/src/index.ts fix: Applied feedback fix: Added back the chai. fix: Restored the chai exclude fix: Removed the async in the sendJsonRpcRequestWithDelay fix: Reduced the timeout to allow tests to finish. fix: Moved timeout test to rateLimiter. fix: Removed comma after LIMIT_DURATION fix: Bumped up the timeout delay to ensure it works in CI. fix: Testing in CI. Removed the .only fix: Adjusted the test delay. fix: Added error details. fix: Added more debug info. fix: Added delay for linux. Debugging in CI. fix: Debugging in CI. Setting test timeout fix: Debugging in CI. Nested promise. fix: Including delay in testfile. Debugging CI. fix: Debugging in CIfix: Debugging in CI. Updated package-log. fix: Extracted setting logic to util function to be used in server startup and test framework fix: Bumped up the timeout for tests on local node. * fix: Moved into its own CI job. * fix: Cleanup * fix: Clean up. --------- Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com> Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: ebadiere <ebadiere@gmail.com>

Add Koa Server Request Timeout

9eda6bf

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>

Nana-EC added enhancement New feature or request P1 labels May 17, 2024

Nana-EC added this to the 0.48.0 milestone May 17, 2024

Nana-EC self-assigned this May 17, 2024

Nana-EC changed the title ~~Add Koa Server Request Timeout~~ feat: Add Koa Server Request Timeout May 17, 2024

Nana-EC requested a review from quiet-node May 17, 2024 04:55

Nana-EC commented May 20, 2024

View reviewed changes

ebadiere force-pushed the 2503-add-server-timeout branch from c775567 to b869431 Compare May 21, 2024 17:26

quiet-node requested changes May 21, 2024

View reviewed changes

ebadiere assigned ebadiere and unassigned Nana-EC May 21, 2024

ebadiere marked this pull request as ready for review May 21, 2024 17:51

ebadiere requested review from AlfredoG87 and a team as code owners May 21, 2024 17:51

quiet-node requested changes May 21, 2024

View reviewed changes

quiet-node removed this from the 0.48.0 milestone May 21, 2024

AlfredoG87 requested changes May 21, 2024

View reviewed changes

ebadiere force-pushed the 2503-add-server-timeout branch from f45244c to 432089b Compare May 24, 2024 18:14

ebadiere added 2 commits May 24, 2024 21:37

fix: Moved into its own CI job.

ee2433f

Signed-off-by: ebadiere <ebadiere@gmail.com>

fix: Cleanup

ed825b6

Signed-off-by: ebadiere <ebadiere@gmail.com>

quiet-node added this to the 0.48.0 milestone May 24, 2024

quiet-node requested changes May 24, 2024

View reviewed changes

fix: Clean up.

7fb85ec

Signed-off-by: ebadiere <ebadiere@gmail.com>

ebadiere force-pushed the 2503-add-server-timeout branch from bb8125c to 7fb85ec Compare May 25, 2024 03:45

Merge branch 'main' into 2503-add-server-timeout

ddbd07c

Signed-off-by: ebadiere <ebadiere@gmail.com>

quiet-node approved these changes May 27, 2024

View reviewed changes

AlfredoG87 approved these changes May 28, 2024

View reviewed changes

quiet-node merged commit 53e5e4b into main May 28, 2024
35 checks passed

quiet-node deleted the 2503-add-server-timeout branch May 28, 2024 15:37

quiet-node mentioned this pull request May 28, 2024

chore: Cherry pick PR2504 #2541

Merged

2 tasks

quiet-node modified the milestones: 0.48.0, 0.48.1 May 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add Koa Server Request Timeout #2504

feat: Add Koa Server Request Timeout #2504

Nana-EC commented May 17, 2024

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

Nana-EC May 20, 2024

ebadiere May 21, 2024

Nana-EC May 20, 2024

ebadiere May 21, 2024

quiet-node May 21, 2024

ebadiere May 21, 2024

quiet-node May 21, 2024

ebadiere May 21, 2024

quiet-node May 21, 2024

ebadiere May 21, 2024

quiet-node May 21, 2024

ebadiere May 21, 2024

quiet-node May 21, 2024

ebadiere May 21, 2024

quiet-node commented May 21, 2024

AlfredoG87 left a comment

AlfredoG87 May 21, 2024

codecov-commenter commented May 23, 2024 •

edited

Loading

quiet-node left a comment

quiet-node May 24, 2024

ebadiere May 25, 2024

quiet-node May 24, 2024

ebadiere May 25, 2024

quiet-node May 24, 2024

ebadiere May 25, 2024

sonarqubecloud bot commented May 25, 2024

quiet-node left a comment

AlfredoG87 left a comment

feat: Add Koa Server Request Timeout #2504

feat: Add Koa Server Request Timeout #2504

Conversation

Nana-EC commented May 17, 2024

github-actions bot commented May 17, 2024 • edited Loading

Tests

github-actions bot commented May 17, 2024 • edited Loading

Acceptance Tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quiet-node commented May 21, 2024

AlfredoG87 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented May 23, 2024 • edited Loading

Codecov Report

quiet-node left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented May 25, 2024

Quality Gate passed

quiet-node left a comment

Choose a reason for hiding this comment

AlfredoG87 left a comment

Choose a reason for hiding this comment

github-actions bot commented May 17, 2024 •

edited

Loading

github-actions bot commented May 17, 2024 •

edited

Loading

codecov-commenter commented May 23, 2024 •

edited

Loading