Update to v1.1.0 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/2
miloszlagan
suggested changes
Jan 14, 2025
Comment on lines
+264
to
+271
| setSrvState({ status: "error", response: undefined }); | ||
| return; | ||
| } | ||
|
|
||
| const serviceName = eStopAction === "go" ? config.goServiceName : config.stopServiceName; | ||
|
|
||
| if (!serviceName) { | ||
| setReqState({ status: "error", value: "Service name is not configured" }); | ||
| setSrvState({ status: "error", response: undefined }); |
There was a problem hiding this comment.
Shouldn't these errors be propagated to the user?
There was a problem hiding this comment.
What was previously contained in the value field. I don't think it was used, instead I put the service response there and if it fails then a notification window will pop up.
Comment on lines
+37
to
+38
| capabilities: allowToggleSrvButton ? [PlayerCapabilities.toggleSrvButtons] : [], | ||
| toggleSrvButton, |
There was a problem hiding this comment.
At least some of them seem to originate from this PR
miloszlagan
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ToggleSrvButton