Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topolotree): new implementation and Hydro Deploy setup #909

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Sep 18, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e7e4cb
Status: ✅  Deploy successful!
Preview URL: https://8065c261.hydroflow.pages.dev
Branch Preview URL: https://pr909.hydroflow.pages.dev

View logs

@shadaj
Copy link
Member Author

shadaj commented Sep 18, 2023

This includes many quality-of-life improvements to Hydro Deploy as well, so probably good to merge this sooner than later.

Copy link

@Saikrishna-Achalla Saikrishna-Achalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In topolotree/topolotree_latency.hydro.py, this is still binary tree support right? Otherwise lgtm

Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

hydro_cli/src/core/hydroflow_crate/build.rs Outdated Show resolved Hide resolved
hydro_cli/src/core/localhost.rs Show resolved Hide resolved
topolotree/src/tests.rs Outdated Show resolved Hide resolved
--


Co-authored-by: zzlk <2418897+zzlk@users.noreply.github.com>
Co-authored-by: Saikrishna Achalla <saikrishnaachalla@Saikrishnas-MacBook-Pro.local>
@shadaj shadaj merged commit 6158a7a into main Dec 1, 2023
18 checks passed
@shadaj shadaj deleted the pr909 branch December 1, 2023 21:17
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 25, 2024
…oject#909)

--

Co-authored-by: Saikrishna Achalla <saikrishnaachalla@Saikrishnas-MacBook-Pro.local>
Co-authored-by: zzlk <2418897+zzlk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants