Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topolotree): perf improvements and better deploy logic #914

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Sep 28, 2023

feat(topolotree): perf improvements and better deploy logic

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b058b6a
Status: ✅  Deploy successful!
Preview URL: https://308fccf0.hydroflow.pages.dev
Branch Preview URL: https://pr914.hydroflow.pages.dev

View logs

@shadaj shadaj changed the title Performance improvements to Topolotree feat(topolotree): perf improvements and better deploy logic Sep 28, 2023
@shadaj shadaj force-pushed the pr914 branch 5 times, most recently from 5df849b to 68ec236 Compare September 30, 2023 01:37
@shadaj shadaj marked this pull request as draft September 30, 2023 02:45
@shadaj shadaj force-pushed the pr914 branch 2 times, most recently from 36635ed to 901ece9 Compare November 29, 2023 21:51
@shadaj shadaj marked this pull request as ready for review November 29, 2023 21:52
@shadaj shadaj force-pushed the pr914 branch 3 times, most recently from 1349589 to fe2436d Compare December 1, 2023 21:17
@shadaj shadaj requested a review from MingweiSamuel December 1, 2023 23:08
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this undoes some of the previous commit? :P

})
.collect::<Vec<_>>();

futures::stream::iter(services_future)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

hydro_cli/src/core/hydroflow_crate/mod.rs Outdated Show resolved Hide resolved
@shadaj shadaj force-pushed the pr914 branch 2 times, most recently from b2f3ed4 to 09966d2 Compare December 11, 2023 21:30
@shadaj
Copy link
Member Author

shadaj commented Dec 11, 2023

Seems like this undoes some of the previous commit? :P

Yeah, had to abandon some of the fault tolerance logic for now 😢

@shadaj shadaj merged commit 7e46da0 into main Dec 11, 2023
33 checks passed
@shadaj shadaj deleted the pr914 branch December 11, 2023 23:37
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants