Forward compatibility patch #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
from
d21340b to
039dabf
Compare
Wendy-Ji
changed the title
CoupledVarThresholdElementSubdomainModifier
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
2 times, most recently
from
71036d7 to
ad8e6b9
Compare
cticenhour
requested changes
Jul 24, 2024
|
Thanks for making this change! I have one comment that needs to be addressed |
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
from
e36969b to
de28413
Compare
cticenhour
requested changes
Sep 10, 2024
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
from
6c89d04 to
3d57bca
Compare
|
Job Documentation on cc2e598 wanted to post the following: View the site here This comment will be updated on new commits. |
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
from
3d57bca to
fd82086
Compare
Wendy-Ji
force-pushed
the
esm_moving_boundary_malamute
branch
from
fd82086 to
cc2e598
Compare
|
We ll need things to propagate to master in moose before this can pass tests. I dont think you ll need to do anything more @Wendy-Ji |
See #160 (comment) |
cticenhour
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the directed energy deposition examples to match the changes that will be made to
CoupledVarThresholdElementSubdomainModifierin the idaholab/moose#27965 pull request. Theapply_initial_conditionsparameter has been replaced byreinitialize_subdomains, and themoving_boundary_nameparameter has been replaced bymoving_boundariesandmoving_boundary_subdomain_pairs. Also has been updated to keep up with idaholab/moose#28314.@sapitts @cticenhour