-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ElementSubdomainModifier
moving boundary and reinitialization
#27965
Conversation
0059e27
to
a74f4cf
Compare
ElementSubdomainModifier
ElementSubdomainModifier
ElementSubdomainModifier
ElementSubdomainModifier
moving boundary and reinitialization
f493768
to
b151191
Compare
Job Documentation on 352a2d3 wanted to post the following: View the site here This comment will be updated on new commits. |
9127e93
to
80fdbc1
Compare
Job Coverage on 352a2d3 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
Hello, this PR will cause some errors when testing |
80fdbc1
to
5795085
Compare
5795085
to
8858167
Compare
2abf514
to
3ff4e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some really minor comments. There are some files that need to be restored -- I will take care of them.
framework/doc/content/source/meshmodifiers/CoupledVarThresholdElementSubdomainModifier.md
Outdated
Show resolved
Hide resolved
Since I am not an independent reviewer as I authored part of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this code improvement. Very well coded and documented. I just have a few comments.
Will be tomorrow, got too busy |
- moving_boundaries and moving_boundary_subdomain_pairs for sideset/nodeset modification - reinitialize_subdomains and old_subdomain_reinitialized to control reinitialization of changed elements refs idaholab#25736
23e4ab4
to
1d806e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
framework/doc/content/source/meshmodifiers/ElementSubdomainModifier.md
Outdated
Show resolved
Hide resolved
00f02ec
to
c29e899
Compare
c29e899
to
1504692
Compare
- more docstring - modified doco - deprecate old boundary parameters
1504692
to
3e645a2
Compare
@Wendy-Ji if you could update your malamute patch please. If you don't have time please just give me write access and I'll finish it up |
The PR is still under review, but I think everything in the patch is up to date now. I've given you write access in case there's something else I've missed |
This pull request addresses several problems with
ElementSubdomainModifier
. The biggest changes in this PR are:ElementSubdomainModifierBase
to contain all the code for changing subdomain, modifying sidesets/nodesets, and reinitialization (ElementSubdomainModifier
now only determines which elements are changing subdomain, and their previous and new subdomain IDs)moving_boundaries
andmoving_boundary_subdomain_pairs
parameters (moving_boundary_name
andcomplement_moving_boundary_name
are replaced by these)reinitialize_subdomains
andold_subdomain_reinitialized
parameters (apply_initial_conditions
is replaced by these)This fixes:
moving_boundary_name
was not updating correctly and thecomplement_moving_boundary_name
was being used instead. This redundancy has been removed, and the ability to choose which 'side' of the moving boundary to use is still retained*-s0*.e
) file was being output at every time step even where there were no subdomain changes.meshChanged()
is now only called when at least one element changes its subdomain.This adds:
moving_boundary_subdomain_pairs
gives greater control over the updates of the boundary. This is based on which pairs of subdomains elements are between (only applies to elements that change subdomain ID). External element sides can now also be added to the boundary.refs #25736
@hugary1995 Continues some of the work from #26254