-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe case where env-map has class & instance #175
Conversation
Need to consider how this works with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiple
This PR should apply to the entire section on reference values matching so that the section reads consistently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various inline comments aimed at improving readability and flow.
I checked the DAA draft and as I understand it the DAA |
I looked for language that mentions 'group' (ps shouldn't we use back quotes to mean artifacts that are in the CoRIM schema - e.g., |
Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org> Co-authored-by: Thomas Fossati <thomas.fossati@linaro.org> Co-authored-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Co-authored-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Co-authored-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
code point 12 is already used by concise-evidence spec for spdm indirect.
Fix #184 Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Andrew Draper <andrew.draper@intel.com>
Co-authored-by: Ned Smith <ned.smith@intel.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The exact changes described in this PR were applied using PR #193 |
Enhance description of matching rules for
environment-map
to permit richer behavior when bothclass
andinstance
fields are present.This fixes issue #172 and is part of the solution to issue #173.
It also fixes #136 (removing the term "group") and #80.
It also fixes #175