Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe case where env-map has class & instance #175

Closed
wants to merge 37 commits into from

Conversation

andrew-draper
Copy link
Collaborator

@andrew-draper andrew-draper commented Dec 6, 2023

Enhance description of matching rules for environment-map to permit richer behavior when both class and instance fields are present.
This fixes issue #172 and is part of the solution to issue #173.
It also fixes #136 (removing the term "group") and #80.
It also fixes #175

@andrew-draper
Copy link
Collaborator Author

Need to consider how this works with the group field.
This field is intended to be used by DAA, as described in https://www.ietf.org/id/draft-ietf-rats-daa-04.html

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple

draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
@nedmsmith
Copy link
Collaborator

This PR should apply to the entire section on reference values matching so that the section reads consistently.

draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
draft-ietf-rats-corim.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various inline comments aimed at improving readability and flow.

@andrew-draper
Copy link
Collaborator Author

Need to consider how this works with the group field. This field is intended to be used by DAA, as described in https://www.ietf.org/id/draft-ietf-rats-daa-04.html

I checked the DAA draft and as I understand it the DAA group field behaves in a similar way to the instance field (but is allocated differently). This change specifies that the Verifier should handle the group field in the same way as the instance field which matches that interpretation.

@nedmsmith
Copy link
Collaborator

This change specifies that the Verifier should handle the group field in the same way as the instance field which matches that interpretation.

I looked for language that mentions 'group' (ps shouldn't we use back quotes to mean artifacts that are in the CoRIM schema - e.g., group-id) but couldn't find any. Maybe I missed it but unless the prose specifically mentions group-id the reader may be confused as to what is the processing behavior. Same goes for instance-id and class-map.

henkbirkholz and others added 26 commits January 18, 2024 11:54
Co-authored-by: Thomas Fossati <tho.ietf@gmail.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Henk Birkholz <henk.birkholz@sit.fraunhofer.de>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Signed-off-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Co-authored-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Co-authored-by: Yogesh Deshpande <yogesh.deshpande@arm.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
code point 12 is already used by concise-evidence spec for spdm indirect.
Fix #184

Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Co-authored-by: Andrew Draper <andrew.draper@intel.com>
Co-authored-by: Ned Smith <ned.smith@intel.com>
Co-authored-by: Ned Smith <ned.smith@intel.com>
Signed-off-by: Thomas Fossati <thomas.fossati@linaro.org>
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-draper
Copy link
Collaborator Author

The exact changes described in this PR were applied using PR #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need definition of what is a group for the purpose of reference value matching
6 participants