Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe case where env-map has class & instance #175

Closed
wants to merge 37 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
ec1ba6a
Describe case where env-map has class & instance
andrew-draper Dec 6, 2023
7d58e37
Respond to comments
andrew-draper Dec 20, 2023
3e08bc5
Textual changes
andrew-draper Dec 20, 2023
a03572b
Rewrite description of triple processing to match recent discussions
andrew-draper Jan 8, 2024
e6ce2f7
Fix build failure and some typos
andrew-draper Jan 9, 2024
69501b8
Update based on review comments
andrew-draper Jan 11, 2024
89f865a
Fix lint
andrew-draper Jan 11, 2024
6c759f5
Fold in review comments
andrew-draper Jan 16, 2024
f1824f7
Break apart multi-sentance lines
andrew-draper Jan 16, 2024
a280a2a
the MEC part of
henkbirkholz Dec 1, 2023
993dfa0
q
henkbirkholz Dec 1, 2023
fb8dec4
added condition-triple-record.cddl
henkbirkholz Dec 1, 2023
cc76d6f
Update cddl/triples-map.cddl
nedmsmith Dec 5, 2023
109759f
fixed some lint
henkbirkholz Dec 6, 2023
47c9560
addressing https://github.com/ietf-rats-wg/draft-ietf-rats-corim/pull…
henkbirkholz Dec 6, 2023
b20e44f
added condition-triple-record.cddl to frags
henkbirkholz Dec 6, 2023
69ade4e
tweaks
thomas-fossati Dec 6, 2023
e82f289
transplant
thomas-fossati Dec 6, 2023
d378a0a
Andy's fix
thomas-fossati Dec 6, 2023
7ee6a11
Add naming consistency
yogeshbdeshpande Dec 6, 2023
e256b43
Add reference to the MEC triple
yogeshbdeshpande Dec 6, 2023
7ef0cac
Update cddl/triples-map.cddl
henkbirkholz Dec 6, 2023
dadd587
Update cddl/mec-endorsement-triple-record.cddl
henkbirkholz Dec 6, 2023
4a82296
align naming
thomas-fossati Dec 6, 2023
cf968f6
Update draft-ietf-rats-corim.md
yogeshbdeshpande Dec 6, 2023
f29bb93
issue tracking
thomas-fossati Dec 6, 2023
c1e9fb0
changed cryptokeys code point to 13
nedmsmith Dec 18, 2023
11e887c
extend the use of tagged-bytes to identifiers
thomas-fossati Dec 20, 2023
97438e1
add test vector
thomas-fossati Dec 20, 2023
9de1032
Andy's comment about uniqueness
thomas-fossati Dec 20, 2023
66c0dd6
do not use the passive form
thomas-fossati Dec 20, 2023
5a4d1fa
plural
thomas-fossati Dec 20, 2023
c688011
scoped uniqueness
thomas-fossati Dec 20, 2023
e88134b
Ned's editorial suggestion
thomas-fossati Jan 3, 2024
c5456de
add references to the tagged-bytes section
thomas-fossati Jan 8, 2024
17a1b11
Fix text describing cryptokeys id to match CDDL
andrew-draper Jan 9, 2024
17c9723
disable cddl-latest as it breaks on the comid-flags example
thomas-fossati Jan 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-rats-corim.md
Original file line number Diff line number Diff line change
Expand Up @@ -1669,9 +1669,9 @@ of the ACS `environment-map`.
If there are no candidate entries then the triple containing the stateful environment does not match.
andrew-draper marked this conversation as resolved.
Show resolved Hide resolved

A stateful environment `environment-map` is a subset of an ACS entry `environment-map`
andrew-draper marked this conversation as resolved.
Show resolved Hide resolved
if each field which is present in the stateful environment `environment-map`
(for example `class`, `instance` etc.)
is also present in the ACS entry, and the CBOR encoded field values in the stateful environment and
if each field (for example `class`, `instance` etc.) which is present in the
andrew-draper marked this conversation as resolved.
Show resolved Hide resolved
andrew-draper marked this conversation as resolved.
Show resolved Hide resolved
stateful environment `environment-map` is also present in the ACS entry,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stateful environment `environment-map` is also present in the ACS entry,
stateful environment `environment-map` is also present in the candidate ACS entry,

and the CBOR encoded field values in the stateful environment and
ACS entry are binary identical.
If a field is not present in the stateful environment `environment-map` then the presence of,
and value of, the corresponding ACS entry field does not affect whether the `environment-map`s are subsets.
Expand Down
Loading