Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BGNPCGN Modern Syriac map 2011 #11

Closed
wants to merge 2 commits into from

Conversation

manuelfuenmayor
Copy link
Contributor

Hi Ron,

I have several transliterations set already. But I'd like you to review this one to see if I'm on track.

Thanks!

Copy link
Contributor

@andrew2net andrew2net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to define at least one test case for each transliteration system. Please add source and expected in the test section.

@ronaldtse ronaldtse force-pushed the romanization-modern-syriac branch from e9b3be5 to cdb602b Compare November 25, 2019 03:49
@ronaldtse
Copy link
Contributor

We need to define at least one test case for each transliteration system. Please add source and expected in the test section.

Right, but it seems that the source reference doesn't provide any examples. Will need to find them...

@AhMohsen46
Copy link
Contributor

@ronaldtse related doc is having arabic equivalents, but it's not basically arabic, I -unforunately- don't think I can do this
however, if we had no other option I may do a little bit of exploration and transliterate the 22 letter language as per the doc, but I can't guarantee a 100% of success and test coverage

@ronaldtse
Copy link
Contributor

Replaced with interscript/maps#167.

@ronaldtse ronaldtse closed this Oct 7, 2021
@ronaldtse ronaldtse deleted the romanization-modern-syriac branch October 7, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants