Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stardust related code #1430

Merged

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Nov 20, 2024

Description of change

PR removes references to stardust client related code, except for the places where identity_stronghold is used, which itself in its implementation relies on it.

This includes parts of the IotaDocument unpacking and Resolver behavior.

IotaDocuments can now be unpacked via IotaDocument::unpack_from_iota_object_data, which is the replacement for the AliasOutput based IotaDocument::unpack_from_output.

IotaDocument::unpack_from_iota_object_data can also be used to parse OnChainIdentity::get_historys outputs, test and examples have been updated to test and showcase this.

IotaClientExt and IotaIdentityClientExt have been removed and their role in Resolver::attach_iota_handler and Resolver::attach_multiple_iota_handlers has been replaced by DidResolutionHandler with the sole function resolve_did to allow defining custom resolvers.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Ran tests locally to check, that existing functionality still works.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Nov 20, 2024
@wulfraem wulfraem requested a review from a team as a code owner November 20, 2024 13:27
Copy link
Contributor

@UMR1352 UMR1352 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nitpicks. Good job

@wulfraem wulfraem changed the base branch from feat/identity-rebased to feat/identity-rebased-cleanup-squash-pre-main-merge-fixed-messages-format-fix-signing-main-merge-2 November 22, 2024 15:52
@wulfraem wulfraem changed the base branch from feat/identity-rebased-cleanup-squash-pre-main-merge-fixed-messages-format-fix-signing-main-merge-2 to feat/identity-rebased November 22, 2024 15:54
@UMR1352 UMR1352 mentioned this pull request Nov 22, 2024
4 tasks
@wulfraem wulfraem changed the base branch from feat/identity-rebased to feat/identity-rebased-cleanup-squash-pre-main-merge-fixed-messages-format-fix-signing-main-merge-2 November 22, 2024 16:09
@wulfraem wulfraem changed the base branch from feat/identity-rebased-cleanup-squash-pre-main-merge-fixed-messages-format-fix-signing-main-merge-2 to feat/identity-rebased November 22, 2024 16:35
@wulfraem wulfraem changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 25, 2024 10:48
@wulfraem wulfraem changed the base branch from feat/identity-rebased-alpha to feat/identity-rebased November 25, 2024 10:58
@wulfraem wulfraem changed the base branch from feat/identity-rebased to feat/identity-rebased-alpha November 25, 2024 11:03
@wulfraem wulfraem force-pushed the feat/remove-stardust-related-code branch from ba2a99a to 8006769 Compare November 25, 2024 11:04
@wulfraem wulfraem merged commit 53fef97 into feat/identity-rebased-alpha Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change A change to the API that requires a major release. Part of "Changed" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants