-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stardust related code #1430
Merged
wulfraem
merged 2 commits into
feat/identity-rebased-alpha
from
feat/remove-stardust-related-code
Nov 25, 2024
Merged
Remove stardust related code #1430
wulfraem
merged 2 commits into
feat/identity-rebased-alpha
from
feat/remove-stardust-related-code
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
itsyaasir
approved these changes
Nov 21, 2024
UMR1352
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nitpicks. Good job
4 tasks
ba2a99a
to
8006769
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change
A change to the API that requires a major release. Part of "Changed" section in changelog
Rust
Related to the core Rust code. Becomes part of the Rust changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
PR removes references to stardust client related code, except for the places where
identity_stronghold
is used, which itself in its implementation relies on it.This includes parts of the
IotaDocument
unpacking andResolver
behavior.IotaDocuments
can now be unpacked viaIotaDocument::unpack_from_iota_object_data
, which is the replacement for theAliasOutput
basedIotaDocument::unpack_from_output
.IotaDocument::unpack_from_iota_object_data
can also be used to parseOnChainIdentity::get_history
s outputs, test and examples have been updated to test and showcase this.IotaClientExt
andIotaIdentityClientExt
have been removed and their role inResolver::attach_iota_handler
andResolver::attach_multiple_iota_handlers
has been replaced byDidResolutionHandler
with the sole functionresolve_did
to allow defining custom resolvers.Type of change
Add an
x
to the boxes that are relevant to your changes.How the change has been tested
Ran tests locally to check, that existing functionality still works.
Change checklist
Add an
x
to the boxes that are relevant to your changes.