Refactor: log viewer improvements details pages #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilsonNet
reviewed
Feb 26, 2025
|
|
||
| import type { JSX } from 'react'; | ||
|
|
||
| export const BlueSearchIcon = (): JSX.Element => ( |
There was a problem hiding this comment.
Icon shouldn't include the color in the name, this can lead people into creating multiple files when all the needed was to add a prop to change color
Francisco2002
force-pushed
the
refactor/log-viewer-improvements-details-pages
branch
from
ec37532 to
c742c1f
Compare
Francisco2002
force-pushed
the
refactor/log-viewer-improvements-details-pages
branch
from
c742c1f to
5326832
Compare
Francisco2002
deleted the
refactor/log-viewer-improvements-details-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactors in Log Viewer
Close #992, #993