Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Parallel with OIDC support #7507

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Test Parallel with OIDC support #7507

merged 1 commit into from
Dec 14, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Dec 13, 2023 •
edited
Loading

Fixes #7491

Proposed Changes

  • Add E2E test for Parallel with OIDC support

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2023
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Dec 13, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c24dab5) 76.16% compared to head (a9ab375) 76.16%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7507   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files         260      260           
  Lines       14456    14456           
=======================================
  Hits        11011    11011           
  Misses       2879     2879           
  Partials      566      566

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 14, 2023
@mgencur mgencur changed the title [WIP] Test Parallel with OIDC support Test Parallel with OIDC support Dec 14, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Dec 14, 2023

/test reconciler-tests

creydr
creydr approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot @mgencur

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@knative-prow knative-prow bot merged commit 56f08d2 into knative:main Dec 14, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OIDC e2e test for Parallel
2 participants
@mgencur @creydr