Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Parallel with OIDC support #7507

Merged
merged 1 commit into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 111 additions & 0 deletions test/auth/features/oidc/parallel.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,24 @@ limitations under the License.
package oidc

import (
"context"
"strconv"

cloudevents "github.com/cloudevents/sdk-go/v2"
"github.com/cloudevents/sdk-go/v2/test"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"knative.dev/eventing/pkg/auth"
"knative.dev/eventing/pkg/reconciler/parallel/resources"
"knative.dev/eventing/test/rekt/resources/addressable"
"knative.dev/eventing/test/rekt/resources/channel_template"
"knative.dev/eventing/test/rekt/resources/parallel"
duckv1 "knative.dev/pkg/apis/duck/v1"
"knative.dev/reconciler-test/pkg/eventshub"
eventasssert "knative.dev/reconciler-test/pkg/eventshub/assert"
"knative.dev/reconciler-test/pkg/feature"
"knative.dev/reconciler-test/pkg/manifest"
"knative.dev/reconciler-test/pkg/resources/service"
)

func ParallelHasAudienceOfInputChannel(parallelName, parallelNamespace string, channelGVR schema.GroupVersionResource, channelKind string) *feature.Feature {
Expand All @@ -40,3 +51,103 @@ func ParallelHasAudienceOfInputChannel(parallelName, parallelNamespace string, c

return f
}

func ParallelWithTwoBranchesOIDC(channelTemplate channel_template.ChannelTemplate) *feature.Feature {
f := feature.NewFeatureNamed("Parallel test.")

parallelName := feature.MakeRandomK8sName("parallel1")
source := feature.MakeRandomK8sName("source1")
sink := feature.MakeRandomK8sName("sink1")
sinkAudience := "sinkAud"
subscriber1Audience := "subscriber1Aud"
subscriber2Audience := "subscriber2Aud"
filter1Audience := "filter1Aud"

eventBody := `{"msg":"test msg"}`
event := test.FullEvent()
_ = event.SetData(cloudevents.ApplicationJSON, []byte(eventBody))

cfg := []manifest.CfgFn{
parallel.WithChannelTemplate(channelTemplate),
}

// Construct two branches
branch1Num := 0
branch2Num := 1
subscriber1 := feature.MakeRandomK8sName("subscriber" + strconv.Itoa(branch1Num))
subscriber2 := feature.MakeRandomK8sName("subscriber" + strconv.Itoa(branch2Num))
filter1 := feature.MakeRandomK8sName("filter" + strconv.Itoa(branch1Num))

f.Setup("install sink", eventshub.Install(sink,
eventshub.OIDCReceiverAudience(sinkAudience),
eventshub.StartReceiver))

// Install Subscribers for both branches.
f.Setup("install subscriber1", eventshub.Install(subscriber1,
eventshub.ReplyWithAppendedData("appended data 1"),
eventshub.OIDCReceiverAudience(subscriber1Audience),
eventshub.StartReceiver))
f.Setup("install subscriber2", eventshub.Install(subscriber2,
eventshub.ReplyWithAppendedData("appended data 2"),
eventshub.OIDCReceiverAudience(subscriber2Audience),
eventshub.StartReceiver))

// Install Filter only for first branch.
f.Setup("install filter1", eventshub.Install(filter1,
eventshub.ReplyWithTransformedEvent(event.Type(), event.Source(), string(event.Data())),
eventshub.OIDCReceiverAudience(filter1Audience),
eventshub.StartReceiver))

// Install a Parallel with two branches
f.Setup("install Parallel", func(ctx context.Context, t feature.T) {
cfg = append(cfg,
parallel.WithReply(&duckv1.Destination{
Ref: service.AsKReference(sink),
Audience: &sinkAudience,
}),
parallel.WithSubscriberAt(branch1Num, &duckv1.Destination{
Ref: service.AsKReference(subscriber1),
Audience: &subscriber1Audience,
}),
parallel.WithSubscriberAt(branch2Num, &duckv1.Destination{
Ref: service.AsKReference(subscriber2),
Audience: &subscriber2Audience,
}),
parallel.WithFilterAt(branch1Num, &duckv1.Destination{
Ref: service.AsKReference(filter1),
Audience: &filter1Audience,
}),
parallel.WithReplyAt(branch1Num, nil),
// The Reply for second branch is same as global reply.
parallel.WithReplyAt(branch2Num, &duckv1.Destination{
Ref: service.AsKReference(sink),
Audience: &sinkAudience,
}),
)

parallel.Install(parallelName, cfg...)(ctx, t)
})
f.Setup("Parallel goes ready", parallel.IsReady(parallelName))
f.Setup("Parallel is addressable", parallel.IsAddressable(parallelName))

f.Requirement("install source", eventshub.Install(
source,
eventshub.StartSenderToResource(parallel.GVR(), parallelName),
eventshub.InputEvent(event),
))

f.Stable("test Parallel with two branches and 1 filter").
Must("deliver event to subscriber1", eventasssert.OnStore(subscriber1).MatchEvent(test.HasId(event.ID())).AtLeast(1)).
Must("deliver event to subscriber2", eventasssert.OnStore(subscriber2).MatchEvent(test.HasId(event.ID())).AtLeast(1)).
Must("deliver event to filter1", eventasssert.OnStore(filter1).MatchEvent(test.HasId(event.ID())).AtLeast(1)).
Must("deliver event from subscriber 1 to reply", eventasssert.OnStore(sink).
MatchEvent(test.HasId(event.ID()), test.HasData([]byte("appended data 1"))).
AtLeast(1),
).
Must("deliver event from subscriber 2 to reply", eventasssert.OnStore(sink).
MatchEvent(test.HasId(event.ID()), test.HasData([]byte("appended data 2"))).
AtLeast(1),
)

return f
}
14 changes: 14 additions & 0 deletions test/auth/oidc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,3 +172,17 @@ func TestSequenceSendsEventsWithOIDCSupport(t *testing.T) {

env.TestSet(ctx, t, oidc.SequenceSendsEventWithOIDC())
}

func TestParallelTwoBranchesWithOIDCSupport(t *testing.T) {
t.Parallel()

ctx, env := global.Environment(
knative.WithKnativeNamespace(system.Namespace()),
knative.WithLoggingConfig,
knative.WithTracingConfig,
k8s.WithEventListener,
environment.Managed(t),
)

env.Test(ctx, t, oidc.ParallelWithTwoBranchesOIDC(channel_template.ImmemoryChannelTemplate()))
}
12 changes: 12 additions & 0 deletions test/rekt/resources/parallel/parallel.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ func WithSubscriberAt(index int, d *duckv1.Destination) manifest.CfgFn {
// Replace "new line" with "new line + spaces".
subscriber["CACerts"] = strings.ReplaceAll(*d.CACerts, "\n", "\n ")
}
if d.Audience != nil {
subscriber["audience"] = *d.Audience
}

cfg["branches"] = branches
}
Expand Down Expand Up @@ -167,6 +170,9 @@ func WithFilterAt(index int, d *duckv1.Destination) manifest.CfgFn {
// Replace "new line" with "new line + spaces".
filter["CACerts"] = strings.ReplaceAll(*d.CACerts, "\n", "\n ")
}
if d.Audience != nil {
filter["audience"] = *d.Audience
}

cfg["branches"] = branches
}
Expand Down Expand Up @@ -213,6 +219,9 @@ func WithReplyAt(index int, d *duckv1.Destination) manifest.CfgFn {
// Replace "new line" with "new line + spaces".
reply["CACerts"] = strings.ReplaceAll(*d.CACerts, "\n", "\n ")
}
if d.Audience != nil {
reply["audience"] = *d.Audience
}

cfg["branches"] = branches
}
Expand Down Expand Up @@ -249,6 +258,9 @@ func WithReply(d *duckv1.Destination) manifest.CfgFn {
// Replace "new line" with "new line + spaces".
reply["CACerts"] = strings.ReplaceAll(*d.CACerts, "\n", "\n ")
}
if d.Audience != nil {
reply["audience"] = *d.Audience
}
}
}

Expand Down
12 changes: 12 additions & 0 deletions test/rekt/resources/parallel/parallel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ spec:
CACerts: |-
{{ .filter.CACerts }}
{{ end }}
{{ if .filter.audience }}
audience: {{ .filter.audience }}
{{ end }}
{{ end }}
{{ if .subscriber }}
subscriber:
Expand All @@ -74,6 +77,9 @@ spec:
CACerts: |-
{{ .subscriber.CACerts }}
{{ end }}
{{ if .subscriber.audience }}
audience: {{ .subscriber.audience }}
{{ end }}
{{ end }}
{{ if .reply }}
reply:
Expand All @@ -91,6 +97,9 @@ spec:
CACerts: |-
{{ .reply.CACerts }}
{{ end }}
{{ if .reply.audience }}
audience: {{ .reply.audience }}
{{ end }}
{{ end }}
{{ end }}
{{ if .reply }}
Expand All @@ -109,4 +118,7 @@ spec:
CACerts: |-
{{ .reply.CACerts }}
{{ end }}
{{ if .reply.audience }}
audience: {{ .reply.audience }}
{{ end }}
{{ end }}
Loading