Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWX-34256: node-wiper fix for custom-dir installs #1388

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

zoxpx
Copy link
Collaborator

@zoxpx zoxpx commented Jan 14, 2024

Adding custom user-volumes to the node-wiper spec

What this PR does / why we need it:

The portworx-install can be customized using user-volumes

  • i.e. /opt/pwx -> /usr/local/portworx by adding spec.Volume -override

    kind: StorageCluster
    apiVersion: core.libopenstorage.org/v1
    spec:
      volumes:
      - name: custom-opt
        mountPath: /opt/pwx
        hostPath:
          path: /usr/local/portworx

However, in such customized installs, for the cleanup to work correctly, we have to provide the same custom user-volumes to the node-wiper image

  • note, the new node-wiper is smart enough to detect the install-dir overrides, and can perform the cleanup/wipe correctly -- but it'll need the correct user-volumes setup

Which issue(s) this PR fixes (optional)
Closes # PWX-34256

Special notes for your reviewer:

Note, the customized px-install (/opt/pwx -> /usr/local/portworx) is being node-wiped correctly after this fix.

Signed-off-by: Zoran Rajic <zox@portworx.com>
Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6b13199) 75.75% compared to head (ab75812) 75.76%.

Files Patch % Lines
drivers/storage/portworx/util/util.go 86.36% 1 Missing and 2 partials ⚠️
drivers/storage/portworx/uninstall.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1388   +/-   ##
=======================================
  Coverage   75.75%   75.76%           
=======================================
  Files          66       66           
  Lines       18723    18746   +23     
=======================================
+ Hits        14183    14202   +19     
- Misses       3531     3533    +2     
- Partials     1009     1011    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoxpx
Copy link
Collaborator Author

zoxpx commented Jan 16, 2024

Thanks Piyush -- merging this PR, will cherry-pick to px-rel-23.10.2 via separate PR.

@zoxpx zoxpx merged commit 676c9e2 into master Jan 16, 2024
@zoxpx zoxpx deleted the PWX-34256_node-wiper_fix branch January 16, 2024 19:07
zoxpx added a commit that referenced this pull request Jan 16, 2024
Signed-off-by: Zoran Rajic <zox@portworx.com>

Manually fixed Conflicts:
	drivers/storage/portworx/util/util.go
zoxpx added a commit that referenced this pull request Jan 16, 2024
…1389)

Signed-off-by: Zoran Rajic <zox@portworx.com>

Manually fixed Conflicts:
	drivers/storage/portworx/util/util.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants