PWX-37760: Update component images when autoUpdateComponents is set #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
=======================================
Coverage 75.97% 75.97%
=======================================
Files 77 77
Lines 20600 20600
=======================================
Hits 15650 15650
Misses 3853 3853
Partials 1097 1097 ☔ View full report in Codecov by Sentry. |
|
This PR is stale because it has been in review for 3 days with no activity. |
nikolaypopov
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: For components like prometheus, alert manager and grafana they do not update desiredImages in the stc when autoUpdateComponents is set to Once or Always. This change will ensure that the component images get updated
Which issue(s) this PR fixes (optional)
Closes # PWX-37760, PWX-37545
Special notes for your reviewer: Similar issue was found for dynamic Plugin images and the fix was similar to this PR