feat(quic): deprecate QUIC draft-29 version support #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dariusc93
approved these changes
Dec 31, 2024
dariusc93
changed the title
dariusc93
requested changes
Jan 1, 2025
elenaf9
reviewed
Jan 4, 2025
|
Friendly ping @tesol2y090. The CI still fails because Also: could we use |
elenaf9
reviewed
Feb 18, 2025
jxs
reviewed
Feb 20, 2025
| @@ -59,6 +59,7 @@ pub struct Config { | |||
| /// If support for draft-29 is enabled servers support draft-29 and version 1 on all | |||
| /// QUIC listening addresses. | |||
| /// As client the version is chosen based on the remote's address. | |||
| #[deprecated(note = "QUIC draft versions are no longer supported")] | |||
| pub support_draft_29: bool, | |||
There was a problem hiding this comment.
we should probably add an allow on our usage of this field, in transports/quic/src/transport.rs:91 .
To allow CI to pass
Co-authored-by: Elena Frank <elena.frank@proton.me>
elenaf9
reviewed
Feb 21, 2025
Comment on lines
+5
to
+7
| - Deprecate `Config::support_draft_29`. | ||
| See [PR 5786](https://github.com/libp2p/rust-libp2p/pull/5786). | ||
|
|
There was a problem hiding this comment.
libp2p-quic-v0.12.0 is already released. You need to bump the version of it to 0.12.1 and move this to a new section above.
There was a problem hiding this comment.
I mean the version of the libp2p-quic crate itself also needs to be bumped :)
elenaf9
changed the title
dariusc93
reviewed
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate support_draft_version field from QUIC protocol.
resolves #3395
Change checklist