-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation Wrap ScalableFM #9
base: main
Are you sure you want to change the base?
Conversation
I'have implemented a function in wrap in which I wrapped the functions of Scalable FM imtegrated with our Hiarchical mesh approach.
1ed1c52
to
6768dce
Compare
6768dce
to
2121e9b
Compare
Quick note on linting (see c886676): I expect linting to be automatically done by |
d48c9e9
to
18ed1b4
Compare
18ed1b4
to
c886676
Compare
@gviga, I'll try to justify the changes I've done in 415cd8d. Please let me know what you think (I'm open to undo anything you don't agree with). As we've discussed in the last meeting, if we sample, we need a As you would expect, we do not implement any Additionally, I've realized With the current approach there's not a lot of changes: we delete
I already have other ideas on how to improve this code... but leaving that for another day. |
@luisfpereira @gviga About 2) I was thinking to add a sampler based on distance functions, similar to what’s done in pyfm, with both Geodesic and Euclidean options. This addition is also useful for our S4A project. Just a thing, I was thinking of farthest point sampling as a method of the Shape class, and then the euclidean distance for PointCloud and finally the geodesic for TriangleMesh (and the TriangleMesh would inherit from PointCloud). |
@GiLonga, my two cents on this: Great idea to have a sampler based on distances. I don't see sampling as a method of the
(btw, really appreciate the suggestions! adding it to our tasks) |
I'have implemented a function in wrap in which I wrapped the functions of Scalable FM imtegrated with our Hiarchical mesh approach.
Note: This is mainly a test on how to work. Some bad practices will be changed in the future.