Update to latest lsp for pull diagnostics #23979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
added
skip package*.json
|
Uggh i forgot about all the tsconfig.json changes necessary for this. This might take me a bit longer. |
rchiodo
commented
Aug 22, 2024
| "source-map-support": "^0.5.12", | ||
| "ts-loader": "^9.2.8", | ||
| "ts-mockito": "^2.5.0", | ||
| "ts-node": "^10.7.0", | ||
| "tsconfig-paths-webpack-plugin": "^3.2.0", | ||
| "typemoq": "^2.1.0", | ||
| "typescript": "4.5.5", | ||
| "typescript": "~5.2", |
There was a problem hiding this comment.
Because of the new way Dirk is exporting the api from the LSP client, I had to update the typescript compiler and the tsconfig.json. It's basically what caused all of these changes.
rchiodo
commented
Aug 22, 2024
| @@ -19,3 +20,7 @@ export function isNotInstalledError(error: Error): boolean { | |||
| const isModuleNoInstalledError = error.message.indexOf('No module named') >= 0; | |||
| return errorObj.code === 'ENOENT' || errorObj.code === 127 || isModuleNoInstalledError; | |||
| } | |||
|
|
|||
| export function untildify(path: string): string { | |||
| return path.replace(/^~($|\/|\\)/, `${os.homedir()}$1`); | |||
There was a problem hiding this comment.
Untilidify doesn't work so well with new typescript. Just asked copilot to generate a new one.
|
@karthiknadig @debonte this looks like it finally works. The root of all of these changes in the LSP client requiring a newer typescript. That rippled through a lot of dependencies. |
…o/vscode-python into rchiodo/update_latest_lsp
debonte
approved these changes
Aug 23, 2024
karthiknadig
approved these changes
Aug 23, 2024
anthonykim1
pushed a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
This is to match the latest updates we've made in pylance. See this PR: microsoft/pyrx#5590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to match the latest updates we've made in pylance.
See this PR:
https://github.com/microsoft/pyrx/pull/5590