forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest lsp for pull diagnostics #23979
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
67ad202
Update to latest lsp
rchiodo 9122dee
Update to use new typescript
rchiodo e7d1813
Fix compiler by upgrading to newer typescript
rchiodo 09bfa48
Fix linter
rchiodo f0a2e4b
Fix untildify
rchiodo 36b4791
Don't use untilidify
rchiodo fb89316
Remove untilidify
rchiodo ce7d310
Make a wrapper around fs-extra
rchiodo e74d1a2
Fix other tests too
rchiodo 7e152db
Remove unneeded space
rchiodo cb6b40f
Remove unnecessary @optional decorators
rchiodo 23b161f
Fix typemoq on ts 5
rchiodo cf24398
Create promise capable typemoq
rchiodo 6b29258
Fix interpreterService test
rchiodo 65fe549
Fix more tests and get browser to build
rchiodo 962cd6e
Fix other locations that need new typemoq
rchiodo 2a6dde2
Merge branch 'main' into rchiodo/update_latest_lsp
rchiodo 3951bce
Undo launch.json changes
rchiodo fd1d687
Merge branch 'rchiodo/update_latest_lsp' of https://github.com/rchiod…
rchiodo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
// Licensed under the MIT License. | ||
|
||
'use strict'; | ||
import * as os from 'os'; | ||
|
||
import { ModuleNotInstalledError } from './errors/moduleNotInstalledError'; | ||
|
||
|
@@ -19,3 +20,7 @@ export function isNotInstalledError(error: Error): boolean { | |
const isModuleNoInstalledError = error.message.indexOf('No module named') >= 0; | ||
return errorObj.code === 'ENOENT' || errorObj.code === 127 || isModuleNoInstalledError; | ||
} | ||
|
||
export function untildify(path: string): string { | ||
return path.replace(/^~($|\/|\\)/, `${os.homedir()}$1`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Untilidify doesn't work so well with new typescript. Just asked copilot to generate a new one. |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the new way Dirk is exporting the api from the LSP client, I had to update the typescript compiler and the tsconfig.json. It's basically what caused all of these changes.