Correct color for RGB14v3 messages #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compared the behavior with the original C++ code.
The context object is adapted there in the LASreadItemCompressed_POINT14_v3::read and LASreadItemCompressed_POINT14_v4::init methods.
The CompressionContext seems to be the work around here since we can not adapted the context value itself. But I think this should be static.
Also the C++ code contains the following:
having both lines in the if block.
I discovered the problem by unzipping a laz file with RGB14_v3 data with both LAStools and laszip4j and seeing different color values in the resulting las file.