-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: support for k8s secrets #330
Conversation
Signed-off-by: ffais <ffais@fbk.eu>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
+ Coverage 63.22% 64.40% +1.17%
==========================================
Files 6 6
Lines 669 545 -124
==========================================
- Hits 423 351 -72
+ Misses 198 144 -54
- Partials 48 50 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Basically LGTM but left tiny comments!
Can you also update docs? |
…x k8s-secret-namespace description Signed-off-by: ffais <ffais@fbk.eu>
I'll work on the documentations in the next days, it will probably also be necessary to update the Helm chart to align it with the documentation. |
Is this going to get merged in? By supporting k8s secrets you can actually remove the GCP support and hand that over to projects like external secrets. This will make this project simpler and more clear cut. |
@morfien101 Yeah, I'd love to merge this pr. I'll update the branch to run the CI. |
@ffais I think we need to grant the get permission of Secret to mysql_controller. Can you add it? Other than that, I think we can merge your pr. mysql-operator/internal/controller/mysql_controller.go Lines 49 to 53 in dc9848b
|
Signed-off-by: ffais <ffais@fbk.eu>
Signed-off-by: ffais <ffais@fbk.eu>
Co-authored-by: Naka Masato <masatonaka1989@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
I've updated config/rbac/role.yaml and all CI passed!
This is a POC to resolve this issue #323. I tested on my cluster and works fine.
There're some issue with my implementation, for example secret namespace and secret key are hard coded.
If you have suggestion on how load secret namespace and key from the CR let me know.