Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename 'gene' to 'cds' in code and public interfaces #1376

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

ivan-aksamentov
Copy link
Member

@ivan-aksamentov ivan-aksamentov commented Jan 9, 2024

Sibling PR in data: nextstrain/nextclade_data#125

Modified input files

The following fields are renamed in the input pathogen.json:

From: aaMotifs[].includeGenes[].gene
To:   aaMotifs[].includeCdses[].cds

From: phenotypeData[].gene
To:   phenotypeData[].cds

From: qc.frameShifts.ignoredFrameShifts[].geneName
To:   qc.frameShifts.ignoredFrameShifts[].cdsName

From: qc.stopCodons.ignoredStopCodons[].geneName
To:   qc.stopCodons.ignoredStopCodons[].cdsName

Modified output files

The following fields are renamed in the output nextclade.json/nextclade.ndjson:

From: results[].missingGenes
To:   results[].missingCdses

The following columns are renamed in the output nextclade.tsv/nextclade.csv:

From: failedGenes
To:   failedCdses

The following fields are renamed in the output nextclade.tree.json:

From: node_atts.missing_genes
To:   node_atts.missing_cdses

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextclade ✅ Ready (Inspect) Visit Preview Jan 9, 2024 3:45pm

@ivan-aksamentov ivan-aksamentov force-pushed the feat/rename-gene-to-cds branch from d420feb to 66d3f21 Compare January 9, 2024 15:32
corneliusroemer added a commit to neherlab/nextclade_data_workflows that referenced this pull request Jan 9, 2024
corneliusroemer added a commit to nextstrain/mpox that referenced this pull request Jan 9, 2024
@ivan-aksamentov ivan-aksamentov merged commit 2e58b16 into master Jan 9, 2024
17 checks passed
@ivan-aksamentov ivan-aksamentov deleted the feat/rename-gene-to-cds branch January 9, 2024 21:15
corneliusroemer added a commit to neherlab/nextclade_data_workflows that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant