fix(esbuild): update peerDep range #30167
Merged
+468
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 4fa79fb.
☁️ Nx Cloud last updated this comment at |
JamesHenry
approved these changes
Feb 25, 2025
Coly010
changed the title
Coly010
force-pushed
the
esbuild/update-version
branch
from
edb8bb8 to
4fa79fb
Compare
jaysoo
approved these changes
Feb 25, 2025
|
Doesn't this mean only 0.19.x releases anyway, given that it's a 0.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
esbuildhas a security advisory for versions up to 0.24.If users attempted to install a version greater than 0.19, they would face peer dep issues with the
@nx/esbuildpackage.Expected Behavior
Expand the peerDep range for
esbuildon the@nx/esbuildpackage to allow users to upgrade.Keep the base version at a lower version to support older OS and VMs which are unsupported by newer versions of
esbuild.Closes #30009