Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: drop unused NeoFS SDK-related code #3054

Closed
wants to merge 1 commit into from
Closed

Conversation

AnnaShaleva
Copy link
Member

#2477 is closed long time ago, I suppose this code is irrelevant anymore.

Ref. nspcc-dev/neo-go#3757 (comment).

#2477 is closed long time
ago, I suppose this code is irrelevant anymore.

Ref. nspcc-dev/neo-go#3757 (comment).

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva
Copy link
Member Author

This change likely shouldn't be reflected in the CHANGELOG because it's not a user-facing thing.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.44%. Comparing base (474d541) to head (09156fd).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-cli/internal/client/sdk.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
+ Coverage   22.43%   22.44%   +0.01%     
==========================================
  Files         791      791              
  Lines       58381    58369      -12     
==========================================
+ Hits        13096    13100       +4     
+ Misses      44386    44371      -15     
+ Partials      899      898       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hack is still relevant cuz we keep using API (SN) client to dial IR. #2477 was closed as unplanned since this should be resolved another way

at the same time, this is a good reminder: with the next SDK upgrade IR will stop using the API client. So, i wont close the PR for now, the code block is easy-to-forget

@roman-khimov
Copy link
Member

Red one. I'd say that control service client is just a different client, it shouldn't reuse SDK client. But that's a different story.

@carpawell
Copy link
Member

Can this be rebased and tried one more time after the latest PR?

@roman-khimov roman-khimov mentioned this pull request Jan 30, 2025
@roman-khimov
Copy link
Member

Included into #3103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants