New SDK #3103
New SDK #3103
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3103 +/- ##
==========================================
+ Coverage 22.50% 22.58% +0.08%
==========================================
Files 752 752
Lines 58375 58126 -249
==========================================
- Hits 13136 13129 -7
+ Misses 44346 44111 -235
+ Partials 893 886 -7 ☔ View full report in Codecov by Sentry. |
Make `Client` interface fit the SDK method: `ReplicateObject(ctx context.Context, id oid.ID, src io.ReadSeeker, signer neofscrypto.Signer, signedReplication bool) (*neofscrypto.Signature, error)`. Use `Action.DecodeString` instead of `eacl.ActionFromString`. Use `Object.ReadFromV2` instead of `object.NewFromV2`. Use `Type.String` instead of `Type.EncodeToString`. Check some vars for nil. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Use `GetAttributes` and `SetAttributes` from SDK instead of api-go `netmap.Attribute`. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
#2477 is closed long time ago, I suppose this code is irrelevant anymore. Ref. nspcc-dev/neo-go#3757 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
force-pushed
the
new-sdk
branch
2 times, most recently
from
0ffd0dc to
509c7e7
Compare
|
Full runs: Only nspcc-dev/neofs-testcases#944 is a problem, but it's the same with the master branch. |
This does the bare minimum to make it work. Conversions are simplified, signatures are handled a bit differently. The expectation is that the behaviour is the same. Notice that we still have api-go in go.mod for control and tree services that use autogenerated code. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
| func (x *multiClient) Conn() *grpc.ClientConn { | ||
| var cc *grpc.ClientConn | ||
|
|
||
| _ = x.iterateClients(context.TODO(), func(c clientcore.Client) error { |
There was a problem hiding this comment.
will context be meaningful in the future?
There was a problem hiding this comment.
I don't think so. We need to get some connection, we're not making any real requests here.
There was a problem hiding this comment.
ok, just do not like context.TODO() in any "release" code
Replaces #3023, #3054. Depends on #3097.