Make oban installer idempotent #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using `on_exists: :skip` when generating the migration, it is
safe for other igniter installers (like the one I'm working on)
to add `{:oban, "~> 2.0"}` to their `installs` list in their
igniters. If oban is present, the installer does nothing, but if
not the user gets a full oban installation.
Also removes an unnecessary `add_dep` call which prompts users
to change the dep in cases where they have something like
`~> 2.0` instead of exactly `~> 2.18`.
|
If you happen to remember, please let me know here if/when this is released 🙇 |
zachdaniel
added a commit
to ash-project/ash_oban
that referenced
this pull request
Jan 27, 2025
This work depends on composing the oban installer, and so can't be merged until this PR is merged: oban-bg/oban#1230
2 tasks
sorentwo
changed the title
sorentwo
added
kind:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using
on_exists: :skipwhen generating the migration, it is safe for other igniter installers (like the one I'm working on) to add{:oban, "~> 2.0"}to theirinstallslist in their igniters. If oban is present, the installer does nothing, but if not the user gets a full oban installation.Also removes an unnecessary
add_depcall which prompts users to change the dep in cases where they have something like~> 2.0instead of exactly~> 2.18.