-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix checks: "R code for possible problems", "Rd files"/"metadata"/"cross-references"/"code/documentation mismatches"; kml_to_csv
bug/tests
#228
Merged
chrisholbrook
merged 57 commits into
ocean-tracking-network:dev
from
mhpob:dev-declare-globals
Aug 14, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:setNames explicitly
…into dev-declare-globals
…into dev-declare-globals
…into dev-declare-globals
kml_to_csv
bug; add testskml_to_csv
bug/tests
This was referenced May 13, 2024
chrisholbrook
approved these changes
Aug 14, 2024
chrisholbrook
added a commit
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to start clearing up some of the "ignorable" output of R CMD check. Commits are small to aid in cherry-picking.
subset
) NSE (Closesdplyr
programming throws R CMD check warnings #190)data.table
suggestion rather than the tidyverse rlang ".data" way as it seems a universal fix for all programming styles and didn't add a dependency.dplyr::across
,stats::setNames
,utils::head
, andutils:tails
kml_to_csv
(Closeskml_to_csv
doesn't check file extension as expected #227) and adds a few unit tests forkml_to_csv
[...]
that isn't supposed to be a link@usage
roxygen tag to@example
intestdata.R
andextdata.R
to get around the need to documentsystem.file
convert_otn_erddap_to_att
test fromexpect_identical
toexpect_equal
to avoid failure related to floating point issues on macOS