add console definition for log record exporter #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the other signals. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
jack-berg
reviewed
Apr 25, 2024
| # Configure exporter. | ||
| exporter: | ||
| # Configure exporter to be console. | ||
| console: {} |
There was a problem hiding this comment.
Its consistent but the console exporter for logs can be tricky to avoid circular loops:
Log framework -> Otel Log Bridge API -> Otel Log SDK -> Console Exporter -> Log Framework ->
Maybe we don't need to worry about that for the sake of config. Its tricky to get right, but still possible to configure.
There was a problem hiding this comment.
Right, to be clear this was possible to configure even before this change :) we just didnt have a console section in the log record exporter called out specifically
jack-berg
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with the other signals.