Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add console definition for log record exporter #84

Merged
merged 1 commit into from
Apr 25, 2024
Merged

add console definition for log record exporter #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions examples/kitchen-sink.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,12 @@ logger_provider:
#
# Environment variable: OTEL_EXPORTER_OTLP_INSECURE, OTEL_EXPORTER_OTLP_LOGS_INSECURE
insecure: false
# Configure a simple span processor.
- simple:
# Configure exporter.
exporter:
# Configure exporter to be console.
console: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its consistent but the console exporter for logs can be tricky to avoid circular loops:
Log framework -> Otel Log Bridge API -> Otel Log SDK -> Console Exporter -> Log Framework ->

Maybe we don't need to worry about that for the sake of config. Its tricky to get right, but still possible to configure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, to be clear this was possible to configure even before this change :) we just didnt have a console section in the log record exporter called out specifically

# Configure log record limits. See also attribute_limits.
limits:
# Configure max log record attribute value size. Overrides attribute_limits.attribute_value_length_limit.
Expand Down
3 changes: 3 additions & 0 deletions schema/logger_provider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@
"properties": {
"otlp": {
"$ref": "common.json#/$defs/Otlp"
},
"console": {
"$ref": "common.json#/$defs/Console"
}
},
"patternProperties": {
Expand Down
Loading