Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing credential format specific parameters from Offer Credential in Appendix #109

Merged
merged 3 commits into from
Nov 10, 2023
Merged

removing credential format specific parameters from Offer Credential in Appendix #109

merged 3 commits into from
Nov 10, 2023

Conversation

paulbastian
Copy link
Contributor

Closes #101

Work left over from #86
We could even delete the whole Credential Offer chapters from the Appendix.

@paulbastian paulbastian linked an issue Nov 7, 2023 that may be closed by this pull request
Remnant of PR#86 #101
Closed
@paulbastian paulbastian changed the title removing credential format specific parameters from Appendix removing credential format specific parameters from Offer Credential in Appendix Nov 7, 2023
jogu
jogu approved these changes Nov 7, 2023
View reviewed changes
openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
Sakurann
Sakurann approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping the examples is good as opposed to removing credential offer sections from credential format appendix entirely.

@Sakurann
Copy link
Collaborator

i don't know if format -> credential format is redundant but it is more accurate...

@jogu @Sakurann
Apply suggestions from code review
9911069 
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
@Sakurann Sakurann merged commit 001c3e3 into main Nov 10, 2023
@Sakurann Sakurann mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogu jogu jogu approved these changes

@Sakurann Sakurann Sakurann approved these changes

@danielfett danielfett Awaiting requested review from danielfett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remnant of PR#86
3 participants
@paulbastian @Sakurann @jogu