-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofread Credential Format Profiles #191
Merged
Sakurann
merged 5 commits into
openid:main
from
selfissued:mbj-proofread-credential-format-profiles-appendix
Jan 12, 2024
Merged
Proofread Credential Format Profiles #191
Sakurann
merged 5 commits into
openid:main
from
selfissued:mbj-proofread-credential-format-profiles-appendix
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
requested review from
jogu,
tlodderstedt,
peppelinux,
tplooker,
awoie and
Sakurann
December 30, 2023 23:38
peppelinux
reviewed
Dec 31, 2023
peppelinux
approved these changes
Dec 31, 2023
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
I applied the |
Sakurann
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO in majority of the places the current text reads ok, but I won't die on this hill.
tplooker
approved these changes
Jan 8, 2024
awoie
reviewed
Jan 10, 2024
Co-authored-by: Oliver Terbu <o.terbu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct issues identified while proofreading the Credential Format Profiles appendix.
(Yes, I'm fully aware that every change here is a merge conflict with #171, due to it moving the section. I'll resolve the merge conflicts after #171 is merged.)