Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPTP-4342] Changed OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY to true #62176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DPTP-4342] Changed OPENSHIFT_INSTALL_AWS_PUBLIC_ONLY to true #62176

wants to merge 1 commit into from
+15 −4

Conversation

hector-vido
Copy link
Contributor

@hector-vido hector-vido commented Feb 27, 2025 •
edited
Loading

This is an effort to avoid the use of NAT inside AWS.
DPTP-4342

This should be applied only on Openshift >= 4.14, but since the verification of this variable is done by the binary, is safe to just set it and don't do any further logic.

This variable is used internally by the installer:
https://github.com/openshift/installer/blob/4c4b4b948bdd328acefd7a5b2d14d5617df49582/pkg/types/aws/platform.go#L249-L253

@openshift-ci-robot
Copy link
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout c6d4d0282c6e138c6bb7e38a289f781dd171e08b]' failed with out:  and error exec: Stdout already set
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from df28810 to 1d8ef19 Compare February 27, 2025 14:42
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@openshift-ci openshift-ci bot requested review from neisw and xueqzhan February 27, 2025 14:45
@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from 1d8ef19 to fe63dd1 Compare February 27, 2025 17:36
@hector-vido
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor Author

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-aws-operator pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.11-e2e-aws-operator pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.17-e2e-aws-operator

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from fe63dd1 to e7c41b9 Compare February 27, 2025 21:17
@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-openshift-tests-private-release-4.14-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from e7c41b9 to b004b8a Compare February 28, 2025 13:40
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/ipi-aws-pre-publicsubnets: chain/ipi-install: duplicate name: ipi-conf-aws-publicsubnets, workflow/openshift-e2e-aws-publicsubnets: chain/ipi-aws-pre-publicsubnets: chain/ipi-install: duplicate name: ipi-conf-aws-publicsubnets]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from b004b8a to f9df47a Compare February 28, 2025 13:57
@openshift-ci-robot
Copy link
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: name of chain in file /var/tmp/gitrepo528481818/ci-operator/step-registry/ipi/conf/aws/publicsubnets/ipi-conf-aws-publicsubnets-chain.yaml should be ipi-conf-aws-publicsubnets
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.17-e2e-aws-operator

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs ERROR:

could not determine changed registry steps: could not load step registry: name of chain in file /var/tmp/gitrepo4030716773/ci-operator/step-registry/ipi/conf/aws/publicsubnets/ipi-conf-aws-publicsubnets-chain.yaml should be ipi-conf-aws-publicsubnets

If the problem persists, please contact Test Platform.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from f9df47a to bc5c4ab Compare February 28, 2025 14:23
@openshift-ci-robot
Copy link
Contributor

@hector-vido, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not determine changed registry steps: could not load step registry: [chain/ipi-aws-pre-publicsubnets: chain/ipi-install: duplicate name: ipi-conf-aws-publicsubnets, workflow/openshift-e2e-aws-publicsubnets: chain/ipi-aws-pre-publicsubnets: chain/ipi-install: duplicate name: ipi-conf-aws-publicsubnets]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from bc5c4ab to ec36c64 Compare February 28, 2025 15:17
@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-aws-ovn pull-ci-openshift-installer-release-4.13-e2e-aws-ovn pull-ci-openshift-installer-release-4.14-okd-scos-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.16-e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from ec36c64 to ccd11a9 Compare February 28, 2025 18:11
@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-aws-ovn pull-ci-openshift-installer-release-4.13-e2e-aws-ovn pull-ci-openshift-installer-release-4.14-okd-scos-e2e-aws-ovn pull-ci-openshift-installer-release-4.16-e2e-openstack-ovn

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido hector-vido force-pushed the force-public-ip-aws-ipi branch from ccd11a9 to 32fabc6 Compare February 28, 2025 20:14
@hector-vido
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-aws-ovn

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@hector-vido: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cli-manager-operator-main-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-cli-manager-operator-release-4.20-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-cli-manager-operator-release-4.19-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-cli-manager-operator-release-4.18-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-cli-manager-operator-release-4.17-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-cli-manager-operator-release-4.16-e2e-aws-operator openshift/cli-manager-operator presubmit Registry content changed
pull-ci-openshift-jaegertracing-jaeger-operator-main-jaeger-product-ocp-4.17-stage-jaeger-stage-tests openshift/jaegertracing-jaeger-operator presubmit Registry content changed
pull-ci-openshift-jaegertracing-jaeger-operator-main-jaeger-product-ocp-4.14-arm-stage-jaeger-stage-tests openshift/jaegertracing-jaeger-operator presubmit Registry content changed
pull-ci-openshift-jaegertracing-jaeger-operator-main-jaeger-product-ocp-4.16-stage-jaeger-stage-tests openshift/jaegertracing-jaeger-operator presubmit Registry content changed
pull-ci-openshift-jaegertracing-jaeger-operator-main-ocp-4.16-hypershift-jaeger-e2e-tests openshift/jaegertracing-jaeger-operator presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.11-e2e-aws-csi-driver openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.11-e2e-aws-csi-driver-no-refreshresource openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.11-e2e-aws-csi-driver-disruptive openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.11-e2e-aws-csi-driver-slow openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.10-e2e-aws-csi-driver openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.10-e2e-aws-csi-driver-no-refreshresource openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.10-e2e-aws-csi-driver-disruptive openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.10-e2e-aws-csi-driver-slow openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.17-e2e-aws-csi-driver openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.17-e2e-aws-csi-driver-no-refreshresource openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.17-e2e-aws-csi-driver-disruptive openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.17-e2e-aws-csi-driver-slow openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.16-e2e-aws-csi-driver openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.16-e2e-aws-csi-driver-no-refreshresource openshift/csi-driver-shared-resource presubmit Registry content changed
pull-ci-openshift-csi-driver-shared-resource-release-4.16-e2e-aws-csi-driver-disruptive openshift/csi-driver-shared-resource presubmit Registry content changed

A total of 21005 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 28, 2025

@hector-vido: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-openshift-apiserver-operator/master/e2e-aws-operator fe63dd1 link unknown /pj-rehearse pull-ci-openshift-cluster-openshift-apiserver-operator-master-e2e-aws-operator
ci/rehearse/openshift/cluster-openshift-apiserver-operator/release-4.17/e2e-aws-operator fe63dd1 link unknown /pj-rehearse pull-ci-openshift-cluster-openshift-apiserver-operator-release-4.17-e2e-aws-operator
ci/rehearse/openshift/installer/release-4.16/e2e-openstack-ovn ccd11a9 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.16-e2e-openstack-ovn
ci/rehearse/openshift/installer/release-4.18/e2e-aws-ovn 32fabc6 link unknown /pj-rehearse pull-ci-openshift-installer-release-4.18-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neisw neisw Awaiting requested review from neisw

@xueqzhan xueqzhan Awaiting requested review from xueqzhan

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hector-vido @openshift-ci-robot