Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Topology defaultLabelSelector to lib-common GetLabelSelector #693

Merged

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Feb 26, 2025

No description provided.

Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/lib-common#606 is needed.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>
@stuggi
Copy link
Contributor

stuggi commented Feb 27, 2025

/retest

@fmount
Copy link
Contributor Author

fmount commented Feb 27, 2025

/test glance-operator-build-kuttl

@fmount
Copy link
Contributor Author

fmount commented Feb 27, 2025

@stuggi good to go as well

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 310b17d into openstack-k8s-operators:main Feb 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants