Add GetLabelSelector utility function #606
Merged
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@olliewalsh @stuggi this is Glance [1] and it might really result in a quick update across the operators that is worth doing before the freeze. I analyzed the context a bit (see [2]) and we could do this and replace all the calls that get a Single label (service, component or anything else) with:
[1] https://paste.opendev.org/show/bc3Zd04FEd2E7rEUZPdn/ |
fmount
force-pushed
the
labelselector
branch
from
ab429c1 to
5037b01
Compare
olliewalsh
reviewed
Feb 27, 2025
fmount
force-pushed
the
labelselector
branch
from
5037b01 to
96695a0
Compare
fmount
force-pushed
the
labelselector
branch
from
96695a0 to
6f6e6c6
Compare
This function is used as utility to get the list of "matchLabels" used as selector for Deployments and StatefulSet. Most of the service operators use to pass a "serviceLabels map[string]string", which is available in the controller(s). This function translates the data structure into a metav1.LabelSelector that we can easily plug to the existing ensureTopology logic provided by infra-operator [1]. [1] https://github.com/openstack-k8s-operators/infra-operator/blob/main/apis/topology/v1beta1/topology_types.go#L126 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is used as utility to get the list of
matchLabelsused asselectorforDeploymentsandStatefulSet. Most of the service operators use to pass aserviceLabels map[string]string, which is available in the controller(s). This function translates the data structure into ametav1.LabelSelectorthat we can easily plug to the existingensureTopologylogic provided by infra-operator [1].[1] https://github.com/openstack-k8s-operators/infra-operator/blob/main/apis/topology/v1beta1/topology_types.go#L126