Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scraperlib 5.0.0rc4 #125

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Use scraperlib 5.0.0rc4 #125

merged 4 commits into from
Jan 9, 2025

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Jan 7, 2025

Changes:

  • move to scraperlib 5.0.0rc4 (and adapt code accordingly)
  • activate strict type checking (needing few type hints + ignore)
  • cleanup unused classes around license generation
  • make test of Wikimedia User-Agent more exact/permissive

@benoit74 benoit74 added this to the 0.1.0 milestone Jan 7, 2025
@benoit74 benoit74 self-assigned this Jan 7, 2025
@benoit74 benoit74 changed the title Use scraperlib 5.0.0rc1 Use scraperlib 5.0.0rc4 Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.01%. Comparing base (9b861f5) to head (ddb65ca).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/asset.py 60.00% 2 Missing ⚠️
scraper/src/mindtouch2zim/client.py 0.00% 1 Missing ⚠️
scraper/src/mindtouch2zim/processor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   51.58%   51.01%   -0.58%     
==========================================
  Files          20       20              
  Lines        1196     1182      -14     
  Branches      137      137              
==========================================
- Hits          617      603      -14     
  Misses        566      566              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review January 9, 2025 10:58
@benoit74 benoit74 requested a review from rgaudin January 9, 2025 10:59
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 372694a into main Jan 9, 2025
10 checks passed
@benoit74 benoit74 deleted the scraperlib5rc1 branch January 9, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants