Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scraperlib 5.0.0rc4 #125

Merged
merged 4 commits into from
Jan 9, 2025

Make test of Wikimedia User-Agent more exact/permissive

ddb65ca
Select commit
Loading
Failed to load commit list.
Merged

Use scraperlib 5.0.0rc4 #125

Make test of Wikimedia User-Agent more exact/permissive
ddb65ca
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 9, 2025 in 1s

51.01% (-0.58%) compared to 9b861f5, passed because coverage increased by 0.24% when compared to adjusted base (50.77%)

View this Pull Request on Codecov

51.01% (-0.58%) compared to 9b861f5, passed because coverage increased by 0.24% when compared to adjusted base (50.77%)

Details

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.01%. Comparing base (9b861f5) to head (ddb65ca).

Files with missing lines Patch % Lines
scraper/src/mindtouch2zim/asset.py 60.00% 2 Missing ⚠️
scraper/src/mindtouch2zim/client.py 0.00% 1 Missing ⚠️
scraper/src/mindtouch2zim/processor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   51.58%   51.01%   -0.58%     
==========================================
  Files          20       20              
  Lines        1196     1182      -14     
  Branches      137      137              
==========================================
- Hits          617      603      -14     
  Misses        566      566              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.