pkp/pkp-lib#10660 fix:cancelling revision file deletes original #10836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
force-pushed
the
i10660-stable-3_3
branch
4 times, most recently
from
dd67430 to
4d3308e
Compare
taslangraham
force-pushed
the
i10660-stable-3_3
branch
from
4d3308e to
dd896a7
Compare
asmecher
requested changes
Jan 30, 2025
| @@ -60,7 +60,7 @@ public function up() { | |||
| $table->bigInteger('submission_file_id')->unsigned(); | |||
| $table->bigInteger('file_id')->unsigned(); | |||
| $table->foreign('submission_file_id')->references('submission_file_id')->on('submission_files'); | |||
| $table->foreign('file_id')->references('file_id')->on('files'); | |||
| $table->foreign('file_id')->references('file_id')->on('files')->onDelete('cascade')->onUpdate('cascade'); | |||
There was a problem hiding this comment.
We aren't using foreign key constraints anywhere in the 3.3.0-x codebase -- and the DBMS might not support it. We also don't introduce database changes between builds on a stable branch. You'll have to find a way to manually implement the cascading delete, I'm afraid!
There was a problem hiding this comment.
Noted. I'll make the necessary updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #10660