Fix RowBinary decoding issue when their sizes exceeds 127 bytes #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a "bug" in
Ch.RowBinary
module where the decoding of type strings fails wgen the size of the string exceeds 127 bytes.The issue raised when working with
Enum16
with more than 8 possible values. As their type strings surpass the 127 byte limit, FunctionClauseError is raised.(** (FunctionClauseError) no function clause matching in Ch.RowBinary.decode_types/3)
:While investigating the strange behavior, noticed that the original implementation of
decode_types/3
function, incorrectly assumes that type string sizes were always encoded as a single byte. This assumption works only for sizes up to 127 bytes. For larger type strings, like those generated byEnum16
with 9 or more values, ClickHouse employs a multi-byte varint encoding.So fix it, based on how
decode_names/4
works, replaced the single-byte size assumption with pattern matching for varint sizes, levering the existing modules varints patterns.