Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

90.1 PRM heat pump data #40

Merged
merged 4 commits into from
Feb 28, 2024
Merged

90.1 PRM heat pump data #40

merged 4 commits into from
Feb 28, 2024

Conversation

AmmarDeh
Copy link
Collaborator

No description provided.

@AmmarDeh
Bump up maximum capacity of unitary air conditioners tables
09b70bf 
Bump up maximum capacity of unitary air conditioners tables including 90.1, 90.1 PRM and IECC
@AmmarDeh
Expand 90.1 heat pump data
e60fd92 
Updated 90.1 heat pump data including heating and cooling requirements.
@AmmarDeh
Add 90.1 PRM heat pump data
cd1bc5d 
Added 90.1 heat pump efficiency requirements (for both heating and cooling)
@AmmarDeh AmmarDeh requested review from leijerry888, lymereJ and weilixu and removed request for leijerry888 February 21, 2024 16:47
lymereJ
lymereJ requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@lymereJ lymereJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmmarDeh - Overall it looks great. I think we do however need to add an equipment_type field, just like for the air-conditioner data. Otherwise, it might be hard to make the difference between some of the records other. Example of values: Unitary and Applied Heat Pumps, Through the Wall, etc.

@AmmarDeh
Modify heat pump prescriptive and PRM data
dbc9942 
Added "equipment_type" to the database tables for both heating and cooling.
Added "rating_condition" as a string instead of numeric for the heat pump heating data.
@AmmarDeh
Copy link
Collaborator Author

@AmmarDeh - Overall it looks great. I think we do however need to add an equipment_type field, just like for the air-conditioner data. Otherwise, it might be hard to make the difference between some of the records other. Example of values: Unitary and Applied Heat Pumps, Through the Wall, etc.

Good catch! This is because the column equipment_type wasn't added to the HP database table (.py file). This should be fixed now!

@AmmarDeh AmmarDeh requested a review from lymereJ February 23, 2024 03:09
@lymereJ lymereJ merged commit 367157a into develop Feb 28, 2024
2 checks passed
@lymereJ lymereJ mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lymereJ lymereJ lymereJ approved these changes

@weilixu weilixu Awaiting requested review from weilixu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmmarDeh @lymereJ