refactor(rust): Pin hashbrown to 0.14 until migrated #19076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
cuviper
reviewed
Oct 3, 2024
| @@ -51,7 +51,7 @@ fallible-streaming-iterator = "0.1.9" | |||
| fast-float = { version = "0.2" } | |||
| flate2 = { version = "1", default-features = false } | |||
| futures = "0.3.25" | |||
| hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde"] } | |||
| hashbrown = { version = "=0.14.5", features = ["rayon", "ahash", "serde"] } | |||
There was a problem hiding this comment.
I don't think pinning helps.
The problem is that polars is using the "raw" feature of hashbrown 0.14 without saying so. You were previously getting that feature indirectly via indexmap's dependency on the same hashbrown, but when indexmap 2.6.0 moves to hashbrown 0.15, you're left with your own hashbrown 0.14 without "raw" anymore. So I think what you really need is this:
-hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde"] }
+hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde", "raw"] }There was a problem hiding this comment.
Or if it's only used by your "dtype-categorical" feature, as the issue suggests, you could add:
dtype-categorical = ["hashbrown/raw"]There was a problem hiding this comment.
Ah... I'm migrating to 0.15 tomorrow anyway so it'll fix itself.
2 tasks
matthewalltop
added a commit
to matthewalltop/ADHD-Analytics
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19063.
Hashbrown 0.15 has backwards-incompatible changes we need to migrate to manually.