Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Pin hashbrown to 0.14 until migrated #19076

Merged
merged 1 commit into from
Oct 2, 2024
Merged

refactor(rust): Pin hashbrown to 0.14 until migrated #19076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ fallible-streaming-iterator = "0.1.9"
fast-float = { version = "0.2" }
flate2 = { version = "1", default-features = false }
futures = "0.3.25"
hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde"] }
hashbrown = { version = "=0.14.5", features = ["rayon", "ahash", "serde"] }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think pinning helps.

The problem is that polars is using the "raw" feature of hashbrown 0.14 without saying so. You were previously getting that feature indirectly via indexmap's dependency on the same hashbrown, but when indexmap 2.6.0 moves to hashbrown 0.15, you're left with your own hashbrown 0.14 without "raw" anymore. So I think what you really need is this:

-hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde"] }
+hashbrown = { version = "0.14", features = ["rayon", "ahash", "serde", "raw"] }

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or if it's only used by your "dtype-categorical" feature, as the issue suggests, you could add:

dtype-categorical = ["hashbrown/raw"]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... I'm migrating to 0.15 tomorrow anyway so it'll fix itself.

hex = "0.4.3"
indexmap = { version = "2", features = ["std", "serde"] }
itoa = "1.0.6"
Expand Down
Loading