Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantees for LSUs #1010

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Guarantees for LSUs #1010

merged 3 commits into from
Jan 30, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Jan 29, 2024 •
edited
Loading

Description

  • Make transaction review support LSUs
  • Make the guarantee view show the divisibility rounded number right away

How to test

  • Stake
  • Make sure that the "Customize guarantees" button is present and that it works

Video

This also shows rounding (we pretend that the resource has a divisibility of 3):

RPReplay_Final1706531161.MP4

PR submission checklist

  • I have tested account to account transfer flow and have confirmed that it works

@kugel3 kugel3 force-pushed the Guarantees-for-LSUs branch 2 times, most recently from 2266aad to 38819a2 Compare January 29, 2024 12:15
@kugel3 kugel3 force-pushed the Guarantees-for-LSUs branch from 38819a2 to 1fecf8f Compare January 29, 2024 12:28
CyonAlexRDX
CyonAlexRDX approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kugel3 kugel3 mentioned this pull request Jan 30, 2024
Closed
1 task
@kugel3 kugel3 merged commit 5675056 into main Jan 30, 2024
6 checks passed
@kugel3 kugel3 deleted the Guarantees-for-LSUs branch January 30, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyonAlexRDX CyonAlexRDX CyonAlexRDX approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kugel3 @CyonAlexRDX @GhenadieVP