Fix redirects #1924
Merged
Fix redirects #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regression was introduced in ca2a162. Redirects like /team.html -> /governance didn't work anymore. In the update from Rocket v0.5.0-rc.3 to v0.5.0, there was a breaking change missed in the changelog of v0.5.0-rc.4 that affected us. https://github.com/rwf2/Rocket/blob/v0.5.0-rc.4/CHANGELOG.md The relevant section in the changelog starts with the line: "The status codes used when built-in guards forward were changed." We used the status code 404 to invoke our custom `not_found` catcher. This custom catcher is responsible for the redirects. When the status code changed to 422, this catcher was not invoked and the redirects were not triggered. This fix simply invokes the catcher for both status codes 404 and 422.
Manishearth
approved these changes
Feb 8, 2024
|
we should check this works on staging (usually takes ~20min max to deploy) and then deploy |
|
thanks @senekor ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1921
This regression was introduced in ca2a162.
In the update from Rocket v0.5.0-rc.3 to v0.5.0, there was a breaking change missed in the changelog of v0.5.0-rc.4 that affected us.
The relevant section in the changelog starts with the line: "The status codes used when built-in guards forward were changed."
We used the status code 404 to invoke our custom
not_foundcatcher. This custom catcher is responsible for the redirects. When the status code changed to 422, this catcher was not invoked and the redirects were not triggered.This fix simply invokes the catcher for both status codes 404 and 422.